playhtml: reevaluate cursor render predicates - #345
Draft
spencerc99 wants to merge 1 commit into
Draft
Conversation
Owner
Author
Preview evidenceChanging shouldRenderCursor immediately hides and restores current remote cursor DOM without another peer update. Open preview · Review all evidence · Commit Current remote cursor filteredTwo clients remain online while the current remote cursor DOM is removed immediately after the predicate changes to false. Open captured page · 1280×720 Current remote cursor restoredThe same current remote cursor reappears immediately after the predicate changes to true, without another peer movement. Open captured page · 1280×720 Published by PR Evidence. Media is temporary and is removed after retention expires. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
shouldRenderCursorchanges.playhtmlpatch changeset.Root cause
CursorClientAwareness.configure()updated the stored cursor options, butshouldRenderCursorwas only read byupdateCursor(). Existing remote cursor DOM was therefore left in its prior state until that peer published another cursor update.Validation
bun run test -- src/cursors/__tests__/configure-render-filter.test.ts(2 tests)bun run testinpackages/playhtml(51 files, 501 tests)bun run buildinpackages/commonbun run buildinpackages/playhtmlbunx tsc --noEmitinpackages/playhtmlDocs and starters
No docs change is needed because the documented
shouldRenderCursorsignature and usage are unchanged. The fix makesconfigure()honor the existing contract immediately. No starter update is needed because imports, options, markup, and CSS are unchanged.