Support primitive page data updates - #303
Open
spencerc99 wants to merge 2 commits into
Open
Conversation
commit: |
Deploying playhtml with
|
| Latest commit: |
f56fc3f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72767ad4.playhtml.pages.dev |
| Branch Preview URL: | https://cx-page-data-primitive-roots.playhtml.pages.dev |
spencerc99
marked this pull request as ready for review
July 13, 2026 05:26
Owner
Author
Code review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Primitive values were held in the page-data map, but the existing replacement helper only mutated object and array proxies. Functional returns were ignored. The initial primitive implementation also retained a stale scalar in proxyByTagAndId after a peer replacement.
Regression coverage
A two-document Yjs test seeds B with cached 0, applies A's remote update to 1, verifies B reads 1, then verifies B's value => value + 1 writes 2.
PR #264 integration
#264 overlaps PageDataChannel.setData for server-gated writes. Keep this branch's root-replacement and PageDataSetter behavior, and derive its gated before snapshot from the same live primitive store value. Then mutate object drafts or use primitive updater returns before buildGatedWriteOps. The server already sends that value as a replace operation. I applied and type-checked that combined hunk against #264.
Validation