Skip to content

[eldritch] file path methods#2354

Open
KCarretto wants to merge 3 commits into
mainfrom
feat/eldritch-libfile-path-methods-3664099661715839956
Open

[eldritch] file path methods#2354
KCarretto wants to merge 3 commits into
mainfrom
feat/eldritch-libfile-path-methods-3664099661715839956

Conversation

@KCarretto

Copy link
Copy Markdown
Collaborator

Adds six new methods to FileLibrary in eldritch-libfile, mimicking Golang's filepath behavior:

  • path_abs
  • path_clean
  • path_base
  • path_join
  • path_dir
  • path_separator

Includes both std and fake (mock) bindings alongside comprehensive tests that verify adherence to Go semantics.


PR created automatically by Jules for task 3664099661715839956 started by @KCarretto

Adds six new methods to `FileLibrary` in `eldritch-libfile`, mimicking Golang's `filepath` behavior:
- `path_abs`
- `path_clean`
- `path_base`
- `path_join`
- `path_dir`
- `path_separator`

Includes both `std` and `fake` (mock) bindings alongside comprehensive tests that verify adherence to Go semantics.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

… and docs

Adds six new methods to `FileLibrary` in `eldritch-libfile`, mimicking Golang's `filepath` behavior:
- `path_abs`
- `path_clean`
- `path_base`
- `path_join`
- `path_dir`
- `path_separator`

Includes both `std` and `fake` (mock) bindings alongside comprehensive tests that verify adherence to Go semantics.
Also updates the user guide `eldritch.md` and the frontend autocomplete hints in `eldritch-docs.json`.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@KCarretto KCarretto changed the title feat(implants): add filepath manipulation methods to eldritch-libfile [eldritch] file path methods May 17, 2026
@KCarretto KCarretto requested a review from hulto May 17, 2026 00:50
@KCarretto KCarretto marked this pull request as ready for review May 17, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant