Add Vue example - #42
Open
dflock wants to merge 1 commit into
Open
Conversation
matubu
requested changes
Mar 30, 2024
| ## Install | ||
|
|
||
| ```console | ||
| $ pnpm i @speed-highlight/core |
Member
There was a problem hiding this comment.
I think it's better to stick with npm in the installation guide for clarity
Comment on lines
+6
to
+12
| const { content = '', lang = 'c' } = defineProps<{ content: string; lang: string }>() | ||
|
|
||
| const highlightedCode = ref('') | ||
|
|
||
| onMounted(async () => { | ||
| highlightedCode.value = await highlightText(content, lang) | ||
| }) |
Member
There was a problem hiding this comment.
I'm not very familiar with Vue, but it seems like the code isn't reactive to updates in the props value. It might be better to make it reactive to the props
lvolland
added a commit
to lvolland/core
that referenced
this pull request
Aug 2, 2026
…d-highlight#42 follows the layout the repo already uses for node-require and node-ts-module, which is what speed-highlight#42 did and this pr did not. takes the theme import from speed-highlight#42 so the component carries its own styling, with the path that resolves: dist/themes is not exported, themes/ is. Co-authored-by: Duncan Lock <dlock@photonic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.