feat(core/sections): allow heading to use section markers - #5029
Merged
Conversation
✅ Deploy Preview for respec-pr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables heading elements to use section marker classes that get copied to their corresponding section elements. The feature allows headings to be marked with classes like "appendix", "informative", and "notoc" which are then automatically applied to the generated section wrappers.
Key changes:
- Added logic to copy specific header classes to section elements
- Defined a set of allowed section classes that can be transferred
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core/sections.js | Implements the core functionality to copy section marker classes from headers to sections |
| tests/spec/core/sections-spec.js | Adds test cases to verify class copying behavior and section type handling |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sidvishnoi
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5022