You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes issue #25 regarding the backward behavior of matrix_power, where the gradient with respect to the exponent parameter was previously not implemented.
Changes
This PR updates the backward function of matrix_power to include a gradient computation w.r.t. the exponent parameter.
Tests
Running pytest locally results in 8 failing tests.
These failures are also present on the current main branch, indicating they are unrelated to this PR.
The failing tests when running pytest locally are:
FAILED tests/test_integration.py::test_module_dtype[WaveletConv-float32-cuda] - RuntimeError: Input type (torch.FloatTensor) and weight type (torch.cuda.FloatTensor) should be the same or input should be a MKLDNN tensor and weight is a dense tensor
FAILED tests/test_integration.py::test_module_dtype[WaveletConv-float64-cuda] - RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cpu and cuda:0! (when checking argument for argument weight in method wrapper_CUDA___slow_conv2d_forward)
FAILED tests/test_integration.py::test_module_dtype[WaveletConv-complex64-cuda] - RuntimeError: Input type (CPUComplexFloatType) and weight type (CUDAComplexFloatType) should be the same
FAILED tests/test_integration.py::test_module_dtype[WaveletConv-complex128-cuda] - RuntimeError: Input type (CPUComplexDoubleType) and weight type (CUDAComplexDoubleType) should be the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes issue #25 regarding the backward behavior of
matrix_power, where the gradient with respect to the exponent parameter was previously not implemented.Changes
This PR updates the backward function of
matrix_powerto include a gradient computation w.r.t. the exponent parameter.Tests
Running pytest locally results in 8 failing tests.
These failures are also present on the current main branch, indicating they are unrelated to this PR.
Authors
Affiliation
Gipsa-lab, University of Grenoble Alpes, CNRS, Grenoble INP