ci: add NVIDIA workers and NVMf {RDMA,TCP} jobs#210
Conversation
mchomnic
requested review from
karlatec,
mhae and
tomzawadzki
and removed request for
mhae
mhae
left a comment
mhae
left a comment
There was a problem hiding this comment.
It's not clear to me why we need to have a common workflow. This workflow is specific to HPE's VM and config (i.e. CX6 and actual NVMe drives).
I also don't want to run nvmf tcp on our VM.
I suggest we keep these jobs separate.
|
@mchomnic , remind me again what HW you are using? Is it ARM or x86? |
|
Hi @mhae, |
mchomnic
force-pushed
the
mch/workers-tests
branch
from
e8ae946 to
f9c3d4b
Compare
mchomnic
changed the title
|
@mhae @tomzawadzki , I changed the approach. I added separated jobs for nvidia's jobs. WDYT? |
mchomnic
force-pushed
the
mch/workers-tests
branch
from
f9c3d4b to
2ab5f37
Compare
|
|
||
| jobs: | ||
| nvidia-nvmf-rdma: | ||
| runs-on: [nvidia-ubuntu-vm] |
There was a problem hiding this comment.
Can we re-label the runners to have more details or use more then one label? E.g. using [nvidia, x64, ubuntu-2404, vm] provides much more information at first glance.
There was a problem hiding this comment.
@mchomnic how about this one? It's much less effort re-labeling the runners now rather than doing it post-merge when there's builds queued up.
There was a problem hiding this comment.
Sure, I'm open for any changes. I just want to discuss it before I will update config, because I have already done twice.
What about [Linux, X86, ubuntu-2404, nvidia-vm, gen-vm]? @tomzawadzki
There was a problem hiding this comment.
Personally I'd go with most generic vm which could be used by jobs which don't have any special dependencies. If more runners are added in future by other companies then this label could be used by everyone. And company-specifc labels could be used to limit jobs to a specific set of runners.
There was a problem hiding this comment.
updated on executor. But in my job I didn't use 'vm' label.
mchomnic
force-pushed
the
mch/workers-tests
branch
2 times, most recently
from
06a40e3 to
7699d83
Compare
mchomnic
force-pushed
the
mch/workers-tests
branch
from
7699d83 to
da3711f
Compare
Run NVMf RDMA and TCP jobs on NVIDIA Ubuntu VMs. Signed-off-by: Marek Chomnicki <mchomnicki@nvidia.com>
mchomnic
force-pushed
the
mch/workers-tests
branch
from
da3711f to
4f22596
Compare
karlatec
left a comment
karlatec
left a comment
There was a problem hiding this comment.
Just a nit about the labels, otherwise LGTM 🔥 🚀 💣
| jobs: | ||
| nvidia-nvmf: | ||
| name: nvidia-nvmf-${{ matrix.name }} | ||
| runs-on: [linux, x64, ubuntu-2404, nvidia-vm] |
There was a problem hiding this comment.
Nit: I'd still split this into separate vm and nvidia labels, but I guess that's just my personal preference.
3 participants
Rename the nvmf-rdma job to vm-nvmf-rdma for generic rdma-vm workers and add a dedicated nvmf-tcp workflow.