Added container configuration system from libfabric-sarus into mater#31
Added container configuration system from libfabric-sarus into mater#31mattnappo wants to merge 8 commits into
libfabric-sarus into mater#31Conversation
mcopik
left a comment
mcopik
left a comment
There was a problem hiding this comment.
Looks very good to me except a minor fix - I will try it locally and try to merge ASAP!
| #REGISTRY_HTTP_TLS_KEY: /certs/domain.unencrypted.key | ||
| #REGISTRY_HTTP_SECRET: supersecrettext | ||
| volumes: | ||
| - /home/ubuntu/rfaas/containers/registry:/var/lib/registry |
There was a problem hiding this comment.
Is that necessary? It seems that it might prevent user from starting a registry.
There was a problem hiding this comment.
Are you referring to the volume mount?
There was a problem hiding this comment.
Yes, the mounting of /home/ubuntu/rfaas/...
There was a problem hiding this comment.
Well, starting a registry does require a volume. The user can mount to wherever they please on their local machine. We should either (a) make it clear that this is a point of configuration, or (b) mount to a set place, like /opt/rfaas/registry or something like that.
There was a problem hiding this comment.
@mattnappo Then I think we need to make it clear that it needs to be adapted by the user. Can we maybe put some hardcoded value like REGISTRY_LOCATION_REPLACE_ME? Otherwise people might miss it easily.
There was a problem hiding this comment.
@mcopik Latest commit should resolve this. The documentation is still a WIP: I am going to add more to it.
I am also currently performing a final test of running the benchmarks with Docker. I will notify you when these tests pass, and then we can merge.
execvp expects a nullptr at the end as a char*. The previous method of doing this resulted in a 'std::logic_error' what(): basic_string::_M_construct null not valid error, since we were trying to construct a std::string with a nullptr. This commit fixes this bug.
2 participants
This PR adds support for Docker, Singularity, and Sarus containers. It also allows for configuration of these environments in
config/executor_manager.json. Most all of the code in this PR is from thelibfabric-sarusbranch, and #29.Opening as draft since I just need to finish testing.