Add async serialization - #29
Open
martilut wants to merge 5 commits into
Open
Conversation
Alexander-Ploskin
left a comment
Alexander-Ploskin
left a comment
Collaborator
There was a problem hiding this comment.
Все хорошо, надо поправить названия методов и сделать асинхронное открытие тестов.
Comment on lines
181
to
182
| public async Task Save(string path) | ||
| { |
Collaborator
There was a problem hiding this comment.
По стайлгайду асинхронные методы имеют суффикс Async, то есть должно быть SaveAsync
Comment on lines
205
to
206
| public async Task Open(string path) | ||
| { |
Comment on lines
51
to
52
| public async void Save(string path) | ||
| { |
async function names fixed
This reverts commit de74154.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.