Fix asset reference updates for Statamic 6.6+ - #271
Merged
Conversation
Statamic 6.6 removed the AssetReferenceUpdater::getConfiguredAssetsFieldContainer() helper and reworked reference updates around an UpdatesReferences trait on fieldtypes (statamic/cms@4730e89). Adopt the new API: drop the custom ResponsiveReferenceUpdater and listener, and let the responsive fieldtype implement replaceAssetReferences() so Statamic's built-in UpdateAssetReferences subscriber handles renames and deletions. Fixes #270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #270.
Statamic 6.6 removed
AssetReferenceUpdater::getConfiguredAssetsFieldContainer()and reworked reference updates around a newUpdatesReferencestrait on fieldtypes (statamic/cms@4730e89). Moving or deleting an asset throwsCall to undefined method ResponsiveReferenceUpdater::getConfiguredAssetsFieldContainer()on Statamic 6.8.This PR adopts the new API:
ResponsiveFieldtypeuses theUpdatesReferencestrait and implementsreplaceAssetReferences(), applying the existing*srcrename/removal rules to the field's data.ResponsiveReferenceUpdaterand the customUpdateResponsiveReferencessubscriber are removed; Statamic's built-inUpdateAssetReferenceslistener now drives the flow (which also gains support forAssetReplacedfor free).tests/Feature/AssetReferenceTest.phptests cover renames (string + array values), nested replicator fields, and deletions, and now pass on Statamic 6.15.