Fix Time comparison to ignore metadata and date context - #281
Merged
Conversation
isBefore() and isAfter() previously used PHP object comparison operators, which compare all object properties including data and date fields. This caused times with identical clock values but different metadata to be ordered incorrectly. Replace object comparison with an explicit clock-minutes comparison path shared by isSame(), isBefore(), and isAfter(). Add regression tests for metadata/date-insensitive comparison and 24:00 ordering.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b597413807
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kylekatarnls
force-pushed
the
fix/time-comparison-by-clock
branch
from
July 9, 2026 19:22
b0191f5 to
e78cb17
Compare
kylekatarnls
approved these changes
Jul 9, 2026
Collaborator
|
Fixed in 4.2.2 |
Contributor
Author
|
Thanks for the quick merge! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time::isBefore()andTime::isAfter()were using PHP object comparison, which is quite brittle. It looked at the$dataand$datefields. Two times with the same hours and minutes could be ordered differently just because they had different metadata attached.This fix makes it so that we compare only the clock time (hours and minutes), matching what
isSame()already did.Bug reproduction
Before the fix, these failed:
Time::fromString('09:00', data: ['label' => 'morning'])vsTime::fromString('09:00', data: ['label' => 'opening']): same clock time, but one could be considered before/after the otherdatereference points was also incorrectly orderedChanges
hours * 60 + minutes) instead of object comparison.isSame(),isBefore(), andisAfter()through this same comparison path.24:00ordering.