Fix VipsDriver autoRotate with sequential access - #328
Merged
Conversation
According to libvips/libvips#4475 you can't rotate JPEGs with sequential access
The autoRotate guard only copied the image into memory when the EXIF orientation did NOT require a rotation, so the rotating orientations (3, 5, 6, 7, 8) still hit "VipsJpeg: out of order read" when saving a large sequential-access JPEG. Only copy into memory when a rotation actually happens. Add a test that loads a large oriented JPEG with the vips driver and saves it. It fails with the old condition and passes with the fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
I pushed a couple of changes on top of this. The condition was inverted: it copied the image into memory only when the orientation did not require a rotation ( I also added a regression test that builds a large (2000x1500) JPEG with a rotating EXIF orientation, loads it with the vips driver and saves it. The original |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to libvips/libvips#4475 you can't rotate JPEGs with sequential access