Use correct "127.0.1.102-127.0.1.106" range format for SH_DBL_ABUSED_… - #71
Open
robertmathews wants to merge 1 commit into
Open
Use correct "127.0.1.102-127.0.1.106" range format for SH_DBL_ABUSED_…#71robertmathews wants to merge 1 commit into
robertmathews wants to merge 1 commit into
Conversation
…FULLHOST rather than ""127.0.1.102-106" The previous format of "127.0.1.102-106" does not work in SpamAssassin 4.0+, and causes false negatives like this (note the incorrect "7f000166-0000006a", suggesting "127.0.1.102-106" is expanded to "127.0.1.102-0.0.0.106"): ``` dbg: uridnsbl: geno.link . geno.link.your_DQS_key.dbl.dq.spamhaus.net -> 127.0.1.102, SH_DBL_ABUSED_FULLHOST, subtest:2130706790-106 dbg: uridnsbl: geno.link . geno.link.your_DQS_key.dbl.dq.spamhaus.net -> 127.0.1.102, SH_DBL_ABUSED_FULLHOST, 7f000166 7f000166-0000006a no ``` After this fix, it correctly matches: ``` dbg: uridnsbl: geno.link . geno.link.your_DQS_key.dbl.dq.spamhaus.net -> 127.0.1.102, SH_DBL_ABUSED_FULLHOST, subtest:2130706790-2130706794 dbg: uridnsbl: geno.link . geno.link.your_DQS_key.dbl.dq.spamhaus.net -> 127.0.1.102, SH_DBL_ABUSED_FULLHOST, 7f000166 7f000166-7f00016a match ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…FULLHOST rather than "127.0.1.102-106"
The previous format of "127.0.1.102-106" does not work in SpamAssassin 4.0+, and causes false negatives like this (note the incorrect "7f000166-0000006a", suggesting "127.0.1.102-106" is expanded to "127.0.1.102-0.0.0.106"):
After this fix, it correctly matches: