Skip to content

Do not disclose dqs api key in default rule description - #65

Open
photoninger wants to merge 2 commits into
spamhaus:masterfrom
photoninger:do-not-disclose-DQS-API-Key-in-default-rule-description
Open

Do not disclose dqs api key in default rule description#65
photoninger wants to merge 2 commits into
spamhaus:masterfrom
photoninger:do-not-disclose-DQS-API-Key-in-default-rule-description

Conversation

@photoninger

Copy link
Copy Markdown
Contributor

remove $prs->{zone} from default rule description.
zone contains the DQS API key.

remove $prs->{zone} from default rule description
remove $prs->{zone} from default rule description
@ricalfieri

Copy link
Copy Markdown
Collaborator

are you using the report template in emails that the end user receives? because the disclosure would only happen if you run "spamassassin -t" or, probably, if you use the report_template.

in that case it would be probably more useful to substitute the zone with, at least, the hash of the listed component, for debugging purposes

@photoninger

Copy link
Copy Markdown
Contributor Author

Only admins get reports from spamassassin.
But others might also send reports to end users and if they don't configure a description for the checks, their DQS API key might leak.
In my opinion it is better to prevent such mistakes. And in the case of HBL there is only one zone which is used, so there is no need to use the zone name in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants