Do not disclose dqs api key in default rule description - #65
Open
photoninger wants to merge 2 commits into
Open
Conversation
remove $prs->{zone} from default rule description
remove $prs->{zone} from default rule description
Collaborator
|
are you using the report template in emails that the end user receives? because the disclosure would only happen if you run "spamassassin -t" or, probably, if you use the report_template. in that case it would be probably more useful to substitute the zone with, at least, the hash of the listed component, for debugging purposes |
Contributor
Author
|
Only admins get reports from spamassassin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove $prs->{zone} from default rule description.
zone contains the DQS API key.