configure,rbldnsd.c: replace mallinfo() with mallinfo2() - #30
Open
orlitzky wants to merge 1 commit into
Open
Conversation
The mallinfo() function from malloc.h is deprecated, and has been replaced by mallinfo2(). Additionally, the "mallinfo" struct that it returns has been replaced by a "mallinfo2" struct. The only difference between the two is that the newer struct contains members of type size_t rather than int, which proved to be too small (leading to overflows). The call to ssprintf() that prints this information has been updated to use the "z" length modifier, which is C99, but which is probably safe by now. Other C99 features are already being used by rbldnsd.
Contributor
Author
|
https://sourceware.org/pipermail/libc-alpha/2021-February/122207.html The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mallinfo()function frommalloc.his deprecated, and has been replaced bymallinfo2(). Additionally, themallinfostruct that it returns has been replaced by amallinfo2struct. The only difference between the two is that the newer struct contains members of typesize_trather thanint, which proved to be too small (leading to overflows).The call to
ssprintf()that prints this information has been updated to use the z length modifier, which is C99, but which is probably safe by now. Other C99 features are already being used by rbldnsd.