ncview: fix for GCC 15+ build#5663
Merged
Merged
Conversation
Contributor
Author
|
Since there are no maintainers, I've added @climbfuji as a reviewer (last commit) and @bernhardkaindl (who did something similar for motif). |
bernhardkaindl
approved these changes
Jul 21, 2026
Contributor
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
bernhardkaindl
enabled auto-merge (squash)
July 21, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets
-std=gnu17when building with GCC 15+ as they now default tognu23andncviewraises errors. (This has been done to many other packages, see #5656 for example.)