Skip to content

ncview: fix for GCC 15+ build#5663

Merged
bernhardkaindl merged 1 commit into
spack:developfrom
mathomp4:ncview-gcc15
Jul 21, 2026
Merged

ncview: fix for GCC 15+ build#5663
bernhardkaindl merged 1 commit into
spack:developfrom
mathomp4:ncview-gcc15

Conversation

@mathomp4

Copy link
Copy Markdown
Contributor

This PR sets -std=gnu17 when building with GCC 15+ as they now default to gnu23 and ncview raises errors. (This has been done to many other packages, see #5656 for example.)

@spackbot-triage spackbot-triage Bot added the update-package Modifications to packages in the repository label Jul 20, 2026
@mathomp4

Copy link
Copy Markdown
Contributor Author

Since there are no maintainers, I've added @climbfuji as a reviewer (last commit) and @bernhardkaindl (who did something similar for motif).

@bernhardkaindl bernhardkaindl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed: Fixes build with %gcc@15.

PS: To clarify, I didn't make the gcc-15 fix for motif, it was done by nicolamori.
I only reviewed, confirmed it, approved and merged it.

@bernhardkaindl

Copy link
Copy Markdown
Contributor

@spackbot run pipeline

@spackbot-app

spackbot-app Bot commented Jul 21, 2026

Copy link
Copy Markdown

I've started that pipeline for you!

@bernhardkaindl
bernhardkaindl enabled auto-merge (squash) July 21, 2026 06:48
@bernhardkaindl
bernhardkaindl merged commit 5195815 into spack:develop Jul 21, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants