Update FloorOcclusionSystem and shaders to use new water cut shader c…#44730
Open
Peptide90 wants to merge 1 commit into
Open
Update FloorOcclusionSystem and shaders to use new water cut shader c…#44730Peptide90 wants to merge 1 commit into
Peptide90 wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
S: Merge Conflict
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
The changelog shouldn't be documenting an internal change. The layperson will not know what it means and will not know how it relates to them or their experience. |
Comment on lines
11
to
13
Contributor
There was a problem hiding this comment.
Claude looking comment write it in english!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hained.
About the PR
This is the content side of space-wizards/RobustToolbox#6815 to change the water shader to use my new shader and chained post shaders.
I'm not sure if Wizards Den is using any water based shaders on their water entities but if so I may need to update them, hopefully not since this is all on the code side.
Why / Balance
Very little player facing really. It allows multiple post shaders to work at once so you can be invisible and affected by water, or see outlines etc.
Technical details
It's a very small PR.
Test plan
Media
See engine PR.
Requirements
Breaking changes
Changelog
🆑