Skip to content

Disable obsolete warnings in event sub generated code #6812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metalgearsloth merged 1 commit into from
Jul 18, 2026
+2 −0
Merged

Disable obsolete warnings in event sub generated code #6812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Robust.Shared.EntitySystemSubscriptionsGenerator/EntitySystemSubscriptionGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
(productionContext, info) =>
{
var (partialTypeInfo, subscriptions) = info;
if (partialTypeInfo.CheckPartialDiagnostic(productionContext, NotPartial))

Check warning on line 71 in Robust.Shared.EntitySystemSubscriptionsGenerator/EntitySystemSubscriptionGenerator.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest) 

'PartialTypeInfo.CheckPartialDiagnostic(SourceProductionContext, DiagnosticDescriptor)' is obsolete: 'Diagnostics from source generators are recommended against, apparently: https://github.com/dotnet/roslyn/issues/71709'

Check warning on line 71 in Robust.Shared.EntitySystemSubscriptionsGenerator/EntitySystemSubscriptionGenerator.cs

View workflow job for this annotation

GitHub Actions / build (Linux) 

'PartialTypeInfo.CheckPartialDiagnostic(SourceProductionContext, DiagnosticDescriptor)' is obsolete: 'Diagnostics from source generators are recommended against, apparently: https://github.com/dotnet/roslyn/issues/71709'

Check warning on line 71 in Robust.Shared.EntitySystemSubscriptionsGenerator/EntitySystemSubscriptionGenerator.cs

View workflow job for this annotation

GitHub Actions / build (Windows) 

'PartialTypeInfo.CheckPartialDiagnostic(SourceProductionContext, DiagnosticDescriptor)' is obsolete: 'Diagnostics from source generators are recommended against, apparently: https://github.com/dotnet/roslyn/issues/71709'
return;

var subscriptionsSyntax = new StringBuilder();
Expand All @@ -86,6 +86,8 @@
using Robust.Shared.GameObjects;
using JetBrains.Annotations;

#pragma warning disable CS0618 // Type or member is obsolete: event handlers will have their own obsoletion warnings, dont need to dupe them

");
partialTypeInfo.WriteHeader(builder);
builder.AppendLine($@"
Expand Down
Loading