refactor: preparations!#12
Open
Fildrance wants to merge 4 commits into
Open
Conversation
…fork name per test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated sln to slnx
Added test project
Added shrimple (well, to some degree) tests for simplest endpoint (status). Hilariously it required waiting for internal init, related to quartz, to pass. And without too much digging i had to resolve to sleep-retry thingy from the start, not really great :( but its kinda required with what we have now! Its a start! yay.
Changes in Program.cs are twofold:
for integration tests to work properly, Program should be public, not internal (as it defaults to), and i extracted some code that would be better-off in separate class into methods for now, to make it all more readable to a degree (that won't bite me when i will merge this into DB-related refactor branch for sure :clueless: