Skip to content

feat: publishing new version now can contain info about sources that were used for version build#11

Open
Fildrance wants to merge 3 commits into
space-wizards:masterfrom
Fildrance:feature/git-metadata-to-build-json
Open

feat: publishing new version now can contain info about sources that were used for version build#11
Fildrance wants to merge 3 commits into
space-wizards:masterfrom
Fildrance:feature/git-metadata-to-build-json

Conversation

@Fildrance

Copy link
Copy Markdown
Member

Why

Sources info can be used for detailed bug report, or just to display additional info in-game for playtesting (if(branchName!=stable) {IsExperimentalGameplayMessageVisible=true}

Changes done

Migration for manifest.db to add new columns for PublishInProgress (all of them are nullable text)

  • SourceUrl (url for repo that contains source code of build)
  • SourceCommitId (commit used for build)
  • SourceBranchName (branch name or tag, used for build)
  • EngineSourceUrl (url for engine source repo, used for build)
  • EngineSourceCommitId (commit of engine submodule, used for build)
  • EngineSourceBranchName (branch/tag name of engine submodule, used for build)

PublishMultiRequest and PublishRequest now both have those new arguments from PublishStartRequestBase base class, all optional.
build.json gets following fields (respectively mapped)

  • built_on_source_url
  • built_on_commit_id
  • built_on_branch_name
  • built_on_engine_url
  • built_on_engine_commit_id
  • built_on_engine_branch_name

What else to do

CVars for changes will be added in space-wizards/RobustToolbox#6749

Script that calls CDN is publish_multi_request.py in ss14 main game repo, should be changed separately.

@Fildrance

Copy link
Copy Markdown
Member Author

Tested part of workflow, including DB (with new fields and without filling them), but without actually finishing publish... this project needs tests and test data for running manual stuff... Also i am a bit lost on why swagger was disabled (its not like it requires a ton of resources?) as it ruins discoverability of API further (and having partial controller does not help too). But refactoring should be done in separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant