feat: publishing new version now can contain info about sources that were used for version build#11
Open
Fildrance wants to merge 3 commits into
Conversation
Member
Author
|
Tested part of workflow, including DB (with new fields and without filling them), but without actually finishing publish... this project needs tests and test data for running manual stuff... Also i am a bit lost on why swagger was disabled (its not like it requires a ton of resources?) as it ruins discoverability of API further (and having partial controller does not help too). But refactoring should be done in separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Sources info can be used for detailed bug report, or just to display additional info in-game for playtesting
(if(branchName!=stable) {IsExperimentalGameplayMessageVisible=true}Changes done
Migration for manifest.db to add new columns for PublishInProgress (all of them are nullable text)
PublishMultiRequest and PublishRequest now both have those new arguments from PublishStartRequestBase base class, all optional.
build.json gets following fields (respectively mapped)
What else to do
CVars for changes will be added in space-wizards/RobustToolbox#6749
Script that calls CDN is publish_multi_request.py in ss14 main game repo, should be changed separately.