fix(player): mount shared PlayerBar via music navigation coordinator - #449
Open
atirna wants to merge 5 commits into
Open
fix(player): mount shared PlayerBar via music navigation coordinator#449atirna wants to merge 5 commits into
atirna wants to merge 5 commits into
Conversation
Hoist PlayerBar to MainWindow so it survives sidebar navigation, centralize music navigation paths in MusicNavigationCoordinator, and remove per-view player bar plumbing that caused remounts and artwork flicker. Fixes sozercan#445 Signed-off-by: Atirna <288419661+atirna@users.noreply.github.com>
…ests Remove per-stack navigation environment wiring superseded by the shared PlayerBar mount, and add MusicNavigationCoordinator regression tests for active-route targeting across tab and pinned sidebar navigation. Fixes sozercan#445 Signed-off-by: Atirna <288419661+atirna@users.noreply.github.com>
SwiftFormat/SwiftLint CI failed on consecutive blank lines left when per-view PlayerBar safeAreaInset blocks were deleted. Signed-off-by: Atirna <288419661+atirna@users.noreply.github.com>
Guest users on Liked Music, Library, or History see SignInRequiredView without a NavigationStack; block coordinator pushes so artist/album taps do not append to a hidden path. Signed-off-by: Atirna <288419661+atirna@users.noreply.github.com>
atirna
force-pushed
the
fix/playerbar-remount
branch
from
August 17, 2026 06:00
e06491a to
902d94e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Each music sidebar view used to mount its own
PlayerBar, so switching Home / Search / Library destroyed the bar, reset@State, and re-ran artwork + navigation prep on every navigation (#445).This moves music navigation paths into
MusicNavigationCoordinator, mounts one sharedPlayerBaron the music detail column inMainWindow, and removes the per-view bar instances plus the oldplayerBarMusicNavigationwiring.Fixes #445
AI Prompt (Optional)
🤖 AI Prompt Used
AI Tool: Cursor Agent (composer-2.5)
Type of Change
Related Issues
Fixes #445
Changes Made
MusicNavigationCoordinatorfor music sidebar paths, active route, and shared player-bar navigation targetsPlayerBarinMainWindowfor the music detail columnPlayerBarinstances and deleted deadplayerBarMusicNavigationplumbing0033-music-navigation-coordinator.mdMusicNavigationCoordinatorTestsTesting
swift test --skip KasetUITests)Verified locally:
swift build --target Kasetswift test --skip KasetUITests(2981 tests)swift test --filter MusicNavigationCoordinatorTestsChecklist
swiftlint --strict && swiftformat .(not installed in this environment)Additional Notes
This follows the structural direction from #445 (central coordinator + single shared bar). Happy to tweak if you'd rather land the ADR separately first.
Made with Cursor