Skip to content

feat(player): add now playing lyrics view and polish synced lyric presentation - #267

Open
yeonfish6040 wants to merge 109 commits into
sozercan:mainfrom
yeonfish6040:player-lyrics-ui-split
Open

feat(player): add now playing lyrics view and polish synced lyric presentation#267
yeonfish6040 wants to merge 109 commits into
sozercan:mainfrom
yeonfish6040:player-lyrics-ui-split

Conversation

@yeonfish6040

@yeonfish6040 yeonfish6040 commented May 28, 2026

Copy link
Copy Markdown

Description

Adds the now playing lyrics surface and refines the synced lyric presentation, artwork layout, scrolling behavior, and thumbnail handling.

AI Prompt (Optional)

🤖 AI Prompt Used

N/A - Manual implementation

AI Tool: OpenAI Codex

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📚 Documentation update
  • 🎨 UI/UX improvement
  • ♻️ Refactoring (no functional changes)
  • 🧪 Test update
  • 🔧 Build/CI configuration

Related Issues

Changes Made

  • Added the now playing lyrics view.
  • Refined synced lyrics wrapping, highlighting, and loading behavior.
  • Improved lyrics scrolling inside the now playing panel.
  • Adjusted lyrics panel sizing and inset handling for the window.
  • Reworked artwork alignment in the now playing layout.
  • Updated thumbnail quality handling.
  • Refined lyrics color presentation.
  • Added and updated tests around lyric display behavior.

Testing

  • Unit tests pass (xcodebuild test -only-testing:KasetTests)
  • Manual testing performed
  • UI tested on macOS 26+

Checklist

  • My code follows the project's style guidelines
  • I have run swiftlint --strict && swiftformat .
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally
  • I have updated documentation if needed
  • I have checked for any performance implications
  • My changes generate no new warnings

Screenshots

Additional Notes

Copilot AI balanced review requested due to automatic review settings May 28, 2026 06:08
Copilot AI reviewed May 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new full-screen "Now Playing" lyrics surface with album art and transport controls, refactors SyncedLyricsDisplayView/SyncedLineView to be reusable and visually richer, and fixes related caching/race issues in CachedAsyncImage and ImageCache.

Changes:

  • New NowPlayingLyricsView presented as an overlay from MainWindow, triggered by tapping the PlayerBar, with a new showNowPlayingLyrics state on PlayerService.
  • Refactor of SyncedLyricsDisplayView to support custom scroll anchor / insets / disabled auto-scroll, and visual polish (color helpers, scale-based sizing, pre-wrapped text) in SyncedLineView.
  • Image caching improvements: CachedAsyncImage no longer flashes during URL changes, and ImageCache keys memory entries by (url, targetSize).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
Sources/Kaset/Views/NowPlayingLyricsView.swift New full-screen now-playing surface with artwork, controls, and lyrics.
Sources/Kaset/Views/SyncedLyricsDisplayView.swift Parameterized scrolling/insets and reworked line styling.
Sources/Kaset/Views/MainWindow.swift Overlays NowPlayingLyricsView and disables hit testing on background.
Sources/Kaset/Views/PlayerBar.swift Tap on player bar opens the now-playing view.
Sources/Kaset/Views/LyricsView.swift Shows small inline spinner when refreshing already-available lyrics.
Sources/Kaset/Views/CachedAsyncImage.swift Prevents flashing/race on URL changes via loadingURL guard.
Sources/Kaset/Utilities/ImageCache.swift Memory cache keyed by url + target size.
Sources/Kaset/Services/Player/PlayerService.swift Adds showNowPlayingLyrics state.
Sources/Kaset/Services/AI/FoundationModelsService.swift Drops await on onPartial callback.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Sources/Kaset/Views/NowPlayingLyricsView.swift Outdated
Comment thread Sources/Kaset/Views/NowPlayingLyricsView.swift
Comment thread Sources/Kaset/Views/NowPlayingLyricsView.swift Outdated
Comment thread Sources/Kaset/Utilities/ImageCache.swift Outdated
Comment thread Sources/Kaset/Views/PlayerBar.swift Outdated
Comment thread Sources/Kaset/Views/NowPlayingLyricsView.swift
@yeonfish6040
Potential fix for pull request finding
2fbb7e1 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 28, 2026 08:23
Copilot AI reviewed May 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Comment thread Sources/Kaset/Views/NowPlayingLyricsView.swift Outdated
Comment thread Sources/Kaset/Views/NowPlayingLyricsView.swift Outdated
Comment thread Sources/Kaset/Views/NowPlayingLyricsView.swift
Comment thread Sources/Kaset/Views/CachedAsyncImage.swift Outdated
Comment thread Sources/Kaset/Utilities/ImageCache.swift Outdated
Comment thread Sources/Kaset/Services/AI/FoundationModelsService.swift
@yeonfish6040

yeonfish6040 commented May 28, 2026

Copy link
Copy Markdown
Author
image Nice

Copilot AI review requested due to automatic review settings May 30, 2026 00:46
Copilot AI reviewed May 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Comment thread Sources/Kaset/Utilities/ImageCache.swift Outdated
Comment thread Sources/Kaset/Services/AI/FoundationModelsService.swift
Comment thread Sources/Kaset/Views/NowPlayingLyricsView.swift
Comment thread Sources/Kaset/Views/PlayerBar.swift Outdated
Comment thread Sources/Kaset/Views/CachedAsyncImage.swift Outdated
sozercan and others added 8 commits May 30, 2026 18:33
@sozercan
Fix release signing (sozercan#279)
a3bb306
@itsmeshibintmz @sozercan
Fix media key skip behavior (sozercan#272)
f46f838 
Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
@itsmeshibintmz @sozercan
Fix PlayerBar layout at narrow widths (sozercan#270)
b886bd8 
Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
@itsmeshibintmz @sozercan
Fix quitting from Dock or AppleScript (sozercan#271)
5c622e2 
Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
@github-actions
Update appcast to v0.10.2
d63d499
@imrashidov @claude @sozercan
Add macOS 15 (Sequoia) deployment compatibility (sozercan#268)
bfd47e4 
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
@cook1e0 @sozercan
Add playlist card hover play button (sozercan#283)
299efc5 
Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
@cook1e0 @sozercan
Fix carousel hover edge clipping (sozercan#284)
7de9730 
Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
github-actions Bot and others added 16 commits July 24, 2026 02:27
@github-actions
Update appcast to v0.13.0 (sozercan#402)
7c0848a 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sozercan
fix: pin What's New notes to app version (sozercan#403)
183cec2 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan @claude
docs: trim agent guidance and remove transcript skill (sozercan#406)
d2a8236 
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
docs: polish README header, and feature list (sozercan#407)
9d0d726
@sozercan
fix: improve YouTube playback reliability (sozercan#408)
dfdb4ba 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@dependabot
chore(deps): bump actions/checkout from 7.0.0 to 7.0.1 in the github-…
5dae9dd 
…actions group (sozercan#410)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions
Update appcast to v0.13.1 (sozercan#411)
2ea911a 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sozercan
feat(youtube): add float-on-top video window control (sozercan#415)
5f73f4a 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@mozyonee @sozercan
fix: add Sign Out to account switcher popover (sozercan#384)
712f19c 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
feat(youtube): add Ask Gemini video conversations (sozercan#416)
bb3a555 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@senshinya @claude @sozercan
feat(l10n): add Simplified and Traditional Chinese localizations (soz…
0576fd5 
…ercan#419)

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
@YuriNachos @claude
fix(lyrics): prevent Bengali romanizer crash on mixed-script text (so…
be0eae7 
…zercan#426)

Co-authored-by: Claude <noreply@anthropic.com>
@hussainarslan @sozercan
feat: refresh Home suggestions on demand (sozercan#425)
f7e6b61 
Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@tsibog
fix(player): stop the page URL being stored as track artwork (sozerca…
53763c1 
…n#447)
@yeonfish6040
Merge player-lyrics-ui-split into main
7436b7c
@tsibog @sozercan
fix(tests): eliminate the two cross-suite unit test flakes (sozercan#448
83e3797 
)

Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings August 23, 2026 23:55
Copilot AI reviewed Aug 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 23, 2026 23:57
Copilot AI reviewed Aug 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 24, 2026 00:10
Copilot AI reviewed Aug 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 24, 2026 02:03
Copilot AI reviewed Aug 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 24, 2026 05:55
Copilot AI reviewed Aug 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.