Skip to content

test PR wf - #5

Open
ceciliaavila wants to merge 2 commits into
southworks/add/teams-api-driftfrom
ceci/test/teams-api-drift
Open

test PR wf#5
ceciliaavila wants to merge 2 commits into
southworks/add/teams-api-driftfrom
ceci/test/teams-api-drift

Conversation

@ceciliaavila

Copy link
Copy Markdown
Collaborator

test

Copilot AI lite review requested due to automatic review settings September 8, 2026 19:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

It introduces an invalid Python dependency specifier and inverts fork/trust gating in the workflow in a way that conflicts with intended “trusted PR” behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the Teams-hosting package dependency declaration and adjusts the “Teams API Drift Detector (PR)” GitHub Actions workflow behavior related to when it runs and when it posts/advises on PRs.

Changes:

  • Changed microsoft-teams-api requirement in the MSTeams hosting package to an exact version string.
  • Modified the drift-detector PR workflow branch filter and inverted multiple “trusted PR” fork-gating conditions.
File summaries
File Description
libraries/microsoft-agents-hosting-msteams/setup.py Updates the declared microsoft-teams-api dependency version specifier.
.github/workflows/teams-api-drift-prs.yml Changes PR branch targeting and alters fork-based gating for advisory/context generation and PR commenting.
Review details

Suppressed comments (2)

.github/workflows/teams-api-drift-prs.yml:246

  • This step is documented as running only for trusted (non-fork) PRs, but the condition was changed to head.repo.fork == true, which prevents commenting on in-repo PRs and tries to comment on fork PRs (where write permissions are typically restricted).
      # Upsert one marker-based summary comment only for trusted pull requests.
      - name: Publish pull-request comment
        if: ${{ always() && github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == true && steps.render-deterministic-report.outcome == 'success' }}

.github/workflows/teams-api-drift-prs.yml:287

  • REQUIRE_ADVISORY is used to decide whether advisory-report failures should fail the workflow. Setting it to true only for fork PRs appears inverted relative to the intended trust policy (and the prior behavior), which will make internal PRs not enforce the advisory checks.
          VALIDATE: ${{ steps.validate-advisory-report.outcome }}
          REQUIRE_ADVISORY: ${{ github.event_name == 'workflow_dispatch' || github.event.pull_request.head.repo.fork == true }}
  • Files reviewed: 2/2 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/teams-api-drift-prs.yml Outdated
Comment thread libraries/microsoft-agents-hosting-msteams/setup.py Outdated
Comment thread .github/workflows/teams-api-drift-prs.yml
@ceciliaavila
ceciliaavila force-pushed the ceci/test/teams-api-drift branch from 84dce34 to 9d785ec Compare September 8, 2026 19:54
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Teams API drift analysis

Compared 2.0.16 to 2.99.901.
blocking: 1 · no-action: 1 · required: 1 · review: 1

  • TSAPI-0002 — blocking · property-type-changed: microsoft_teams.api.models.channel_data.channel_info.ChannelInfo.id
  • TSAPI-0003 — review · symbol-added: microsoft_teams.api.models.channel_data.manual_review_capability.ManualReviewCapability
  • TSAPI-0004 — required · property-type-changed: microsoft_teams.api.models.channel_data.notification_info.NotificationInfo.alert

Download the complete deterministic report and evidence

@ceciliaavila
ceciliaavila force-pushed the ceci/test/teams-api-drift branch 2 times, most recently from 3403507 to 2cdd5a4 Compare September 8, 2026 20:30
@ceciliaavila
ceciliaavila force-pushed the ceci/test/teams-api-drift branch from 2cdd5a4 to d81e27a Compare September 8, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants