test PR wf - #5
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
It introduces an invalid Python dependency specifier and inverts fork/trust gating in the workflow in a way that conflicts with intended “trusted PR” behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Teams-hosting package dependency declaration and adjusts the “Teams API Drift Detector (PR)” GitHub Actions workflow behavior related to when it runs and when it posts/advises on PRs.
Changes:
- Changed
microsoft-teams-apirequirement in the MSTeams hosting package to an exact version string. - Modified the drift-detector PR workflow branch filter and inverted multiple “trusted PR” fork-gating conditions.
File summaries
| File | Description |
|---|---|
| libraries/microsoft-agents-hosting-msteams/setup.py | Updates the declared microsoft-teams-api dependency version specifier. |
| .github/workflows/teams-api-drift-prs.yml | Changes PR branch targeting and alters fork-based gating for advisory/context generation and PR commenting. |
Review details
Suppressed comments (2)
.github/workflows/teams-api-drift-prs.yml:246
- This step is documented as running only for trusted (non-fork) PRs, but the condition was changed to
head.repo.fork == true, which prevents commenting on in-repo PRs and tries to comment on fork PRs (where write permissions are typically restricted).
# Upsert one marker-based summary comment only for trusted pull requests.
- name: Publish pull-request comment
if: ${{ always() && github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == true && steps.render-deterministic-report.outcome == 'success' }}
.github/workflows/teams-api-drift-prs.yml:287
REQUIRE_ADVISORYis used to decide whether advisory-report failures should fail the workflow. Setting it to true only for fork PRs appears inverted relative to the intended trust policy (and the prior behavior), which will make internal PRs not enforce the advisory checks.
VALIDATE: ${{ steps.validate-advisory-report.outcome }}
REQUIRE_ADVISORY: ${{ github.event_name == 'workflow_dispatch' || github.event.pull_request.head.repo.fork == true }}
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
84dce34 to
9d785ec
Compare
Teams API drift analysisCompared
|
3403507 to
2cdd5a4
Compare
2cdd5a4 to
d81e27a
Compare
test