build(deps): bump nanoid and mocha - #294
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [nanoid](https://github.com/ai/nanoid) to 3.3.18 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Updates `nanoid` from 3.3.6 to 3.3.18 - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/3.3.18/CHANGELOG.md) - [Commits](ai/nanoid@3.3.6...3.3.18) Updates `mocha` from 10.2.0 to 10.8.2 - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md) - [Commits](mochajs/mocha@v10.2.0...v10.8.2) --- updated-dependencies: - dependency-name: nanoid dependency-version: 3.3.18 dependency-type: indirect - dependency-name: mocha dependency-version: 10.8.2 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues
Fixed security issues:
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="yarn.lock" line_range="1424-1426" />
<code_context>
+ version "0.0.8"
+ resolved "https://registry.npmjs.org/mute-stream/-/mute-stream-0.0.8.tgz"
+
+nanoid@^3.3.6:
+ version "3.3.6"
+ resolved "https://registry.npmjs.org/nanoid/-/nanoid-3.3.6.tgz"
+
+napi-build-utils@^1.0.1:
</code_context>
<issue_to_address>
**issue (broader_impact):** The two lockfiles resolve Nano ID differently: Yarn remains pinned to 3.3.6 while npm resolves 3.3.18. Release and prerelease workflows run `yarn install --frozen-lockfile`, so published builds do not receive the Nano ID fixes this PR claims to deliver.
**Triggers:** When building or publishing through the Yarn-based release workflows.
**Suggested fix:** Regenerate the Yarn lock entry so `nanoid@^3.3.6` resolves to 3.3.18 as well.
```suggestion
nanoid@^3.3.6:
version "3.3.18"
resolved "https://registry.npmjs.org/nanoid/-/nanoid-3.3.18.tgz"
```
</issue_to_address>
### Comment 2
<location path="yarn.lock" line_range="6-67" />
<code_context>
+ resolved "https://registry.yarnpkg.com/@esbuild/linux-s390x/-/linux-s390x-0.18.10.tgz#84318e86ee1e377c603c7b5359f5f67771eddd99"
+
"@esbuild/linux-x64@0.18.10":
- "integrity" "sha512-wj2KRsCsFusli+6yFgNO/zmmLslislAWryJnodteRmGej7ZzinIbMdsyp13rVGde88zxJd5vercNYK9kuvlZaQ=="
- "resolved" "https://registry.npmjs.org/@esbuild/linux-x64/-/linux-x64-0.18.10.tgz"
- "version" "0.18.10"
+ version "0.18.10"
+ resolved "https://registry.npmjs.org/@esbuild/linux-x64/-/linux-x64-0.18.10.tgz"
+
+"@esbuild/netbsd-x64@0.18.10":
</code_context>
<issue_to_address>
**🚨 issue (security):** The regenerated Yarn lockfile removes lockfile-pinned integrity hashes from dependencies whose `resolved` npm URLs contain no hash. Consequently, Yarn's frozen release installs no longer authenticate those archives against a checksum committed to the repository and accept changed content served at the same URL.
**Triggers:** When a registry or intermediary serves altered package content at an unchanged npm URL.
**Suggested fix:** Regenerate `yarn.lock` with integrity migration enabled and retain an `integrity` value or hash-bearing resolved URL for every package.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+1424
to
+1426
| nanoid@^3.3.6: | ||
| version "3.3.6" | ||
| resolved "https://registry.npmjs.org/nanoid/-/nanoid-3.3.6.tgz" |
Contributor
There was a problem hiding this comment.
issue (broader_impact): The two lockfiles resolve Nano ID differently: Yarn remains pinned to 3.3.6 while npm resolves 3.3.18. Release and prerelease workflows run yarn install --frozen-lockfile, so published builds do not receive the Nano ID fixes this PR claims to deliver.
Triggers: When building or publishing through the Yarn-based release workflows.
Suggested fix: Regenerate the Yarn lock entry so nanoid@^3.3.6 resolves to 3.3.18 as well.
Suggested change
| nanoid@^3.3.6: | |
| version "3.3.6" | |
| resolved "https://registry.npmjs.org/nanoid/-/nanoid-3.3.6.tgz" | |
| nanoid@^3.3.6: | |
| version "3.3.18" | |
| resolved "https://registry.npmjs.org/nanoid/-/nanoid-3.3.18.tgz" |
Comment on lines
+6
to
-67
|
|
||
| "@esbuild/win32-arm64@0.18.10": | ||
| version "0.18.10" | ||
| resolved "https://registry.yarnpkg.com/@esbuild/win32-arm64/-/win32-arm64-0.18.10.tgz#f12fcff13b9dbd3e80481f4cb6282708ce7794bb" | ||
|
|
||
| "@esbuild/win32-ia32@0.18.10": | ||
| version "0.18.10" | ||
| resolved "https://registry.yarnpkg.com/@esbuild/win32-ia32/-/win32-ia32-0.18.10.tgz#e369e9bedf6b548a62b284320c6de08982d045da" | ||
|
|
||
| "@esbuild/win32-x64@0.18.10": | ||
| version "0.18.10" | ||
| resolved "https://registry.yarnpkg.com/@esbuild/win32-x64/-/win32-x64-0.18.10.tgz#141d8e73b74252eef46a5433f69d15890d82b5e3" | ||
|
|
||
| "@eslint-community/eslint-utils@^4.2.0": | ||
| "integrity" "sha512-gB8T4H4DEfX2IV9zGDJPOBgP1e/DbfCPDTtEqUMckpvzS1OYtva8JdFYBqMwYk7xAQ429WGF/UPqn8uQ//h2vQ==" | ||
| "resolved" "https://registry.npmjs.org/@eslint-community/eslint-utils/-/eslint-utils-4.2.0.tgz" | ||
| "version" "4.2.0" | ||
| version "4.2.0" | ||
| resolved "https://registry.npmjs.org/@eslint-community/eslint-utils/-/eslint-utils-4.2.0.tgz" | ||
| dependencies: | ||
| "eslint-visitor-keys" "^3.3.0" | ||
| eslint-visitor-keys "^3.3.0" | ||
|
|
||
| "@eslint-community/regexpp@^4.4.0": | ||
| "integrity" "sha512-A9983Q0LnDGdLPjxyXQ00sbV+K+O+ko2Dr+CZigbHWtX9pNfxlaBkMR8X1CztI73zuEyEBXTVjx7CE+/VSwDiQ==" | ||
| "resolved" "https://registry.npmjs.org/@eslint-community/regexpp/-/regexpp-4.4.0.tgz" | ||
| "version" "4.4.0" | ||
| version "4.4.0" | ||
| resolved "https://registry.npmjs.org/@eslint-community/regexpp/-/regexpp-4.4.0.tgz" | ||
|
|
||
| "@eslint/eslintrc@^2.0.1": | ||
| "integrity" "sha512-eFRmABvW2E5Ho6f5fHLqgena46rOj7r7OKHYfLElqcBfGFHHpjBhivyi5+jOEQuSpdc/1phIZJlbC2te+tZNIw==" | ||
| "resolved" "https://registry.npmjs.org/@eslint/eslintrc/-/eslintrc-2.0.1.tgz" | ||
| "version" "2.0.1" | ||
| dependencies: | ||
| "ajv" "^6.12.4" | ||
| "debug" "^4.3.2" | ||
| "espree" "^9.5.0" | ||
| "globals" "^13.19.0" | ||
| "ignore" "^5.2.0" | ||
| "import-fresh" "^3.2.1" | ||
| "js-yaml" "^4.1.0" | ||
| "minimatch" "^3.1.2" | ||
| "strip-json-comments" "^3.1.1" | ||
| version "2.0.1" | ||
| resolved "https://registry.npmjs.org/@eslint/eslintrc/-/eslintrc-2.0.1.tgz" | ||
| dependencies: | ||
| ajv "^6.12.4" | ||
| debug "^4.3.2" | ||
| espree "^9.5.0" | ||
| globals "^13.19.0" | ||
| ignore "^5.2.0" | ||
| import-fresh "^3.2.1" | ||
| js-yaml "^4.1.0" | ||
| minimatch "^3.1.2" | ||
| strip-json-comments "^3.1.1" | ||
|
|
||
| "@eslint/js@8.36.0": | ||
| "integrity" "sha512-lxJ9R5ygVm8ZWgYdUweoq5ownDlJ4upvoWmO4eLxBYHdMo+vZ/Rx0EN6MbKWDJOSUGrqJy2Gt+Dyv/VKml0fjg==" | ||
| "resolved" "https://registry.npmjs.org/@eslint/js/-/js-8.36.0.tgz" | ||
| "version" "8.36.0" | ||
| version "8.36.0" | ||
| resolved "https://registry.npmjs.org/@eslint/js/-/js-8.36.0.tgz" | ||
|
|
||
| "@humanwhocodes/config-array@^0.11.8": | ||
| "integrity" "sha512-UybHIJzJnR5Qc/MsD9Kr+RpO2h+/P1GhOwdiLPXK5TWk5sgTdu88bTD9UP+CKbPPh5Rni1u0GjAdYQLemG8g+g==" | ||
| "resolved" "https://registry.npmjs.org/@humanwhocodes/config-array/-/config-array-0.11.8.tgz" | ||
| "version" "0.11.8" | ||
| version "0.11.8" | ||
| resolved "https://registry.npmjs.org/@humanwhocodes/config-array/-/config-array-0.11.8.tgz" | ||
| dependencies: | ||
| "@humanwhocodes/object-schema" "^1.2.1" | ||
| "debug" "^4.1.1" | ||
| "minimatch" "^3.0.5" | ||
| debug "^4.1.1" | ||
| minimatch "^3.0.5" | ||
|
|
||
| "@humanwhocodes/module-importer@^1.0.1": | ||
| "integrity" "sha512-bxveV4V8v5Yb4ncFTT3rPSgZBOpCkjfK0y4oVVVJwIuDVBRMDXrPyXRL988i5ap9m9bnyEEjWfm5WkBmtffLfA==" | ||
| "resolved" "https://registry.npmjs.org/@humanwhocodes/module-importer/-/module-importer-1.0.1.tgz" | ||
| "version" "1.0.1" | ||
| version "1.0.1" | ||
| resolved "https://registry.npmjs.org/@humanwhocodes/module-importer/-/module-importer-1.0.1.tgz" | ||
|
|
||
| "@humanwhocodes/object-schema@^1.2.1": | ||
| "integrity" "sha512-ZnQMnLV4e7hDlUvw8H+U8ASL02SS2Gn6+9Ac3wGGLIe7+je2AeAOxPY+izIPJDfFDb7eDjev0Us8MO1iFRN8hA==" | ||
| "resolved" "https://registry.npmjs.org/@humanwhocodes/object-schema/-/object-schema-1.2.1.tgz" | ||
| "version" "1.2.1" | ||
| version "1.2.1" | ||
| resolved "https://registry.npmjs.org/@humanwhocodes/object-schema/-/object-schema-1.2.1.tgz" | ||
|
|
||
| "@jsdevtools/ez-spawn@^3.0.4": | ||
| "integrity" "sha512-f5DRIOZf7wxogefH03RjMPMdBF7ADTWUMoOs9kaJo06EfwF+aFhMZMDZxHg/Xe12hptN9xoZjGso2fdjapBRIA==" | ||
| "resolved" "https://registry.npmjs.org/@jsdevtools/ez-spawn/-/ez-spawn-3.0.4.tgz" | ||
| "version" "3.0.4" | ||
| version "3.0.4" | ||
| resolved "https://registry.npmjs.org/@jsdevtools/ez-spawn/-/ez-spawn-3.0.4.tgz" | ||
| dependencies: | ||
| "call-me-maybe" "^1.0.1" | ||
| "cross-spawn" "^7.0.3" |
Contributor
There was a problem hiding this comment.
🚨 issue (security): The regenerated Yarn lockfile removes lockfile-pinned integrity hashes from dependencies whose resolved npm URLs contain no hash. Consequently, Yarn's frozen release installs no longer authenticate those archives against a checksum committed to the repository and accept changed content served at the same URL.
Triggers: When a registry or intermediary serves altered package content at an unchanged npm URL.
Suggested fix: Regenerate yarn.lock with integrity migration enabled and retain an integrity value or hash-bearing resolved URL for every package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps nanoid to 3.3.18 and updates ancestor dependency mocha. These dependencies need to be updated together.
Updates
nanoidfrom 3.3.6 to 3.3.18Release notes
Sourced from nanoid's releases.
Changelog
Sourced from nanoid's changelog.
Commits
9ad9805Release 3.3.18 version55e50a0Update CI actione10f8d4Update index.native.js (#606)73d6716Release 3.3.17 versionf9d13f1Sync 0 size behaviour with PostCSS 59760e11Release 3.3.16 versione835c9bfix(non-secure): clamp negative size to prevent infinite loop (#601)96dd086Update CI actionba0bc3bDo not create latest release for v36819724Release 3.3.15 versionMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for nanoid since your current version.
Updates
mochafrom 10.2.0 to 10.8.2Release notes
Sourced from mocha's releases.
... (truncated)
Changelog
Sourced from mocha's changelog.
... (truncated)
Commits
05097dbchore(main): release 10.8.2 (#5239)14e640edocs: indicate 'exports' interface does not work in browsers (#5181)881e3b0chore: fix docs builds by re-adding eleventy and ignoring gitignore again (#5...f054accfix: test link in html reporter (#5224)e536ab2build(deps): bump the github-actions group with 1 update (#5132)ba0fefefix: support errors with circular dependencies in object values with --parall...f44f71bchore(main): release 10.8.1 (#5238)f72bc17fix: handle case of invalid package.json with no explicit config (#5198)68803b6fix: use accurate test links in HTML reporter (#5228)d8ca270fix: Typos on mochajs.org (#5237)Maintainer changes
This version was pushed to npm by voxpelli, a new releaser for mocha since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.