build(deps): bump js-yaml and mocha - #292
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) to 4.3.1 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Updates `js-yaml` from 4.1.0 to 4.3.1 - [Changelog](https://github.com/nodeca/js-yaml/blob/4.3.1/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.3.1) Updates `mocha` from 10.2.0 to 10.8.2 - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md) - [Commits](mochajs/mocha@v10.2.0...v10.8.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.3.1 dependency-type: indirect - dependency-name: mocha dependency-version: 10.8.2 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
This was referenced Aug 9, 2026
Closed
Closed
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues
Fixed security issues:
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="yarn.lock" line_range="1244-1245" />
<code_context>
+ version "4.3.0"
+ resolved "https://registry.npmjs.org/js-sdsl/-/js-sdsl-4.3.0.tgz"
+
+js-yaml@^4.1.0:
+ version "4.1.0"
+ resolved "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.0.tgz"
+ dependencies:
+ argparse "^2.0.1"
</code_context>
<issue_to_address>
**issue (broader_impact):** The lockfiles resolve `js-yaml` differently: `npm ci` installs 4.3.1, while `yarn install --frozen-lockfile` installs the vulnerable 4.1.0. The repository's publish and prerelease workflows use Yarn, so this security upgrade is ineffective on those paths and CI validates a different dependency graph.
**Triggers:** When dependencies are installed with Yarn, including the publish and prerelease workflows.
**Suggested fix:** Regenerate `yarn.lock` so the `js-yaml@^4.1.0` entry resolves to 4.3.1.
```suggestion
version "4.3.1"
resolved "https://registry.npmjs.org/js-yaml/-/js-yaml-4.3.1.tgz"
```
</issue_to_address>
### Comment 2
<location path="yarn.lock" line_range="6-67" />
<code_context>
+ resolved "https://registry.yarnpkg.com/@esbuild/linux-s390x/-/linux-s390x-0.18.10.tgz#84318e86ee1e377c603c7b5359f5f67771eddd99"
+
"@esbuild/linux-x64@0.18.10":
- "integrity" "sha512-wj2KRsCsFusli+6yFgNO/zmmLslislAWryJnodteRmGej7ZzinIbMdsyp13rVGde88zxJd5vercNYK9kuvlZaQ=="
- "resolved" "https://registry.npmjs.org/@esbuild/linux-x64/-/linux-x64-0.18.10.tgz"
- "version" "0.18.10"
+ version "0.18.10"
+ resolved "https://registry.npmjs.org/@esbuild/linux-x64/-/linux-x64-0.18.10.tgz"
+
+"@esbuild/netbsd-x64@0.18.10":
</code_context>
<issue_to_address>
**🚨 issue (security):** The regenerated Yarn lockfile removes integrity checksums throughout the dependency graph, including entries whose replacement `resolved` URL has no checksum fragment. Yarn therefore has no pinned digest against which to verify downloaded tarballs and accepts altered content served from those URLs.
**Triggers:** When a registry, proxy, cache, or network path serves a tarball differing from the one used to generate the lockfile.
**Suggested fix:** Regenerate the lockfile with a modern Yarn version that records `integrity` values, and avoid committing a lockfile that strips existing checksums.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+1244
to
+1245
| version "4.1.0" | ||
| resolved "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.0.tgz" |
Contributor
There was a problem hiding this comment.
issue (broader_impact): The lockfiles resolve js-yaml differently: npm ci installs 4.3.1, while yarn install --frozen-lockfile installs the vulnerable 4.1.0. The repository's publish and prerelease workflows use Yarn, so this security upgrade is ineffective on those paths and CI validates a different dependency graph.
Triggers: When dependencies are installed with Yarn, including the publish and prerelease workflows.
Suggested fix: Regenerate yarn.lock so the js-yaml@^4.1.0 entry resolves to 4.3.1.
Suggested change
| version "4.1.0" | |
| resolved "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.0.tgz" | |
| version "4.3.1" | |
| resolved "https://registry.npmjs.org/js-yaml/-/js-yaml-4.3.1.tgz" |
Comment on lines
+6
to
-67
|
|
||
| "@esbuild/win32-arm64@0.18.10": | ||
| version "0.18.10" | ||
| resolved "https://registry.yarnpkg.com/@esbuild/win32-arm64/-/win32-arm64-0.18.10.tgz#f12fcff13b9dbd3e80481f4cb6282708ce7794bb" | ||
|
|
||
| "@esbuild/win32-ia32@0.18.10": | ||
| version "0.18.10" | ||
| resolved "https://registry.yarnpkg.com/@esbuild/win32-ia32/-/win32-ia32-0.18.10.tgz#e369e9bedf6b548a62b284320c6de08982d045da" | ||
|
|
||
| "@esbuild/win32-x64@0.18.10": | ||
| version "0.18.10" | ||
| resolved "https://registry.yarnpkg.com/@esbuild/win32-x64/-/win32-x64-0.18.10.tgz#141d8e73b74252eef46a5433f69d15890d82b5e3" | ||
|
|
||
| "@eslint-community/eslint-utils@^4.2.0": | ||
| "integrity" "sha512-gB8T4H4DEfX2IV9zGDJPOBgP1e/DbfCPDTtEqUMckpvzS1OYtva8JdFYBqMwYk7xAQ429WGF/UPqn8uQ//h2vQ==" | ||
| "resolved" "https://registry.npmjs.org/@eslint-community/eslint-utils/-/eslint-utils-4.2.0.tgz" | ||
| "version" "4.2.0" | ||
| version "4.2.0" | ||
| resolved "https://registry.npmjs.org/@eslint-community/eslint-utils/-/eslint-utils-4.2.0.tgz" | ||
| dependencies: | ||
| "eslint-visitor-keys" "^3.3.0" | ||
| eslint-visitor-keys "^3.3.0" | ||
|
|
||
| "@eslint-community/regexpp@^4.4.0": | ||
| "integrity" "sha512-A9983Q0LnDGdLPjxyXQ00sbV+K+O+ko2Dr+CZigbHWtX9pNfxlaBkMR8X1CztI73zuEyEBXTVjx7CE+/VSwDiQ==" | ||
| "resolved" "https://registry.npmjs.org/@eslint-community/regexpp/-/regexpp-4.4.0.tgz" | ||
| "version" "4.4.0" | ||
| version "4.4.0" | ||
| resolved "https://registry.npmjs.org/@eslint-community/regexpp/-/regexpp-4.4.0.tgz" | ||
|
|
||
| "@eslint/eslintrc@^2.0.1": | ||
| "integrity" "sha512-eFRmABvW2E5Ho6f5fHLqgena46rOj7r7OKHYfLElqcBfGFHHpjBhivyi5+jOEQuSpdc/1phIZJlbC2te+tZNIw==" | ||
| "resolved" "https://registry.npmjs.org/@eslint/eslintrc/-/eslintrc-2.0.1.tgz" | ||
| "version" "2.0.1" | ||
| dependencies: | ||
| "ajv" "^6.12.4" | ||
| "debug" "^4.3.2" | ||
| "espree" "^9.5.0" | ||
| "globals" "^13.19.0" | ||
| "ignore" "^5.2.0" | ||
| "import-fresh" "^3.2.1" | ||
| "js-yaml" "^4.1.0" | ||
| "minimatch" "^3.1.2" | ||
| "strip-json-comments" "^3.1.1" | ||
| version "2.0.1" | ||
| resolved "https://registry.npmjs.org/@eslint/eslintrc/-/eslintrc-2.0.1.tgz" | ||
| dependencies: | ||
| ajv "^6.12.4" | ||
| debug "^4.3.2" | ||
| espree "^9.5.0" | ||
| globals "^13.19.0" | ||
| ignore "^5.2.0" | ||
| import-fresh "^3.2.1" | ||
| js-yaml "^4.1.0" | ||
| minimatch "^3.1.2" | ||
| strip-json-comments "^3.1.1" | ||
|
|
||
| "@eslint/js@8.36.0": | ||
| "integrity" "sha512-lxJ9R5ygVm8ZWgYdUweoq5ownDlJ4upvoWmO4eLxBYHdMo+vZ/Rx0EN6MbKWDJOSUGrqJy2Gt+Dyv/VKml0fjg==" | ||
| "resolved" "https://registry.npmjs.org/@eslint/js/-/js-8.36.0.tgz" | ||
| "version" "8.36.0" | ||
| version "8.36.0" | ||
| resolved "https://registry.npmjs.org/@eslint/js/-/js-8.36.0.tgz" | ||
|
|
||
| "@humanwhocodes/config-array@^0.11.8": | ||
| "integrity" "sha512-UybHIJzJnR5Qc/MsD9Kr+RpO2h+/P1GhOwdiLPXK5TWk5sgTdu88bTD9UP+CKbPPh5Rni1u0GjAdYQLemG8g+g==" | ||
| "resolved" "https://registry.npmjs.org/@humanwhocodes/config-array/-/config-array-0.11.8.tgz" | ||
| "version" "0.11.8" | ||
| version "0.11.8" | ||
| resolved "https://registry.npmjs.org/@humanwhocodes/config-array/-/config-array-0.11.8.tgz" | ||
| dependencies: | ||
| "@humanwhocodes/object-schema" "^1.2.1" | ||
| "debug" "^4.1.1" | ||
| "minimatch" "^3.0.5" | ||
| debug "^4.1.1" | ||
| minimatch "^3.0.5" | ||
|
|
||
| "@humanwhocodes/module-importer@^1.0.1": | ||
| "integrity" "sha512-bxveV4V8v5Yb4ncFTT3rPSgZBOpCkjfK0y4oVVVJwIuDVBRMDXrPyXRL988i5ap9m9bnyEEjWfm5WkBmtffLfA==" | ||
| "resolved" "https://registry.npmjs.org/@humanwhocodes/module-importer/-/module-importer-1.0.1.tgz" | ||
| "version" "1.0.1" | ||
| version "1.0.1" | ||
| resolved "https://registry.npmjs.org/@humanwhocodes/module-importer/-/module-importer-1.0.1.tgz" | ||
|
|
||
| "@humanwhocodes/object-schema@^1.2.1": | ||
| "integrity" "sha512-ZnQMnLV4e7hDlUvw8H+U8ASL02SS2Gn6+9Ac3wGGLIe7+je2AeAOxPY+izIPJDfFDb7eDjev0Us8MO1iFRN8hA==" | ||
| "resolved" "https://registry.npmjs.org/@humanwhocodes/object-schema/-/object-schema-1.2.1.tgz" | ||
| "version" "1.2.1" | ||
| version "1.2.1" | ||
| resolved "https://registry.npmjs.org/@humanwhocodes/object-schema/-/object-schema-1.2.1.tgz" | ||
|
|
||
| "@jsdevtools/ez-spawn@^3.0.4": | ||
| "integrity" "sha512-f5DRIOZf7wxogefH03RjMPMdBF7ADTWUMoOs9kaJo06EfwF+aFhMZMDZxHg/Xe12hptN9xoZjGso2fdjapBRIA==" | ||
| "resolved" "https://registry.npmjs.org/@jsdevtools/ez-spawn/-/ez-spawn-3.0.4.tgz" | ||
| "version" "3.0.4" | ||
| version "3.0.4" | ||
| resolved "https://registry.npmjs.org/@jsdevtools/ez-spawn/-/ez-spawn-3.0.4.tgz" | ||
| dependencies: | ||
| "call-me-maybe" "^1.0.1" | ||
| "cross-spawn" "^7.0.3" |
Contributor
There was a problem hiding this comment.
🚨 issue (security): The regenerated Yarn lockfile removes integrity checksums throughout the dependency graph, including entries whose replacement resolved URL has no checksum fragment. Yarn therefore has no pinned digest against which to verify downloaded tarballs and accepts altered content served from those URLs.
Triggers: When a registry, proxy, cache, or network path serves a tarball differing from the one used to generate the lockfile.
Suggested fix: Regenerate the lockfile with a modern Yarn version that records integrity values, and avoid committing a lockfile that strips existing checksums.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps js-yaml to 4.3.1 and updates ancestor dependency mocha. These dependencies need to be updated together.
Updates
js-yamlfrom 4.1.0 to 4.3.1Changelog
Sourced from js-yaml's changelog.
... (truncated)
Commits
86e91b84.3.1 releasedc3cc4b0Backport quadratic complexity fix for !!omap33d05b54.3.0 released663bfabDrop demo publish, to not override new v5 one.1cb8c7bAdd v4-legacy tag for publish02f27afRestore umd builds back to es58be84edFix es5 compatibility59423c6ReplacemaxMergeSeqLengthoption withmaxTotalMergeKeys(more robust). Ba...6842ef6doc polish590dbab4.2.0 releasedUpdates
mochafrom 10.2.0 to 10.8.2Release notes
Sourced from mocha's releases.
... (truncated)
Changelog
Sourced from mocha's changelog.
... (truncated)
Commits
05097dbchore(main): release 10.8.2 (#5239)14e640edocs: indicate 'exports' interface does not work in browsers (#5181)881e3b0chore: fix docs builds by re-adding eleventy and ignoring gitignore again (#5...f054accfix: test link in html reporter (#5224)e536ab2build(deps): bump the github-actions group with 1 update (#5132)ba0fefefix: support errors with circular dependencies in object values with --parall...f44f71bchore(main): release 10.8.1 (#5238)f72bc17fix: handle case of invalid package.json with no explicit config (#5198)68803b6fix: use accurate test links in HTML reporter (#5228)d8ca270fix: Typos on mochajs.org (#5237)Maintainer changes
This version was pushed to npm by voxpelli, a new releaser for mocha since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.