Skip to content

refactor(all-services): remove extra code from controller and used by injecting service - #89

Merged
yeshamavani merged 4 commits into
masterfrom
GH-88
Oct 9, 2025
Merged

refactor(all-services): remove extra code from controller and used by injecting service#89
yeshamavani merged 4 commits into
masterfrom
GH-88

Conversation

@vaibhavbhalla2505

@vaibhavbhalla2505 vaibhavbhalla2505 commented Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Remove extra code from controllers and used by injecting service in it.

Fixes # (issue)

GH-88

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@vaibhavbhalla2505 vaibhavbhalla2505 self-assigned this Jun 20, 2025
@vaibhavbhalla2505 vaibhavbhalla2505 linked an issue Jun 20, 2025 that may be closed by this pull request
Remove extra code from service's controllers #88
Closed
@vaibhavbhalla2505
vaibhavbhalla2505 force-pushed the GH-88 branch 2 times, most recently from 2798758 to 19fc9a4 Compare June 23, 2025 06:30
Tyagi-Sunny
Tyagi-Sunny reviewed Jun 25, 2025
View reviewed changes
Comment thread services/subscription-service/src/controllers/billing-customer.controller.ts Outdated
Tyagi-Sunny
Tyagi-Sunny reviewed Jun 25, 2025
View reviewed changes
Comment thread services/subscription-service/src/controllers/billing-invoice.controller.ts Outdated
Tyagi-Sunny
Tyagi-Sunny reviewed Jun 25, 2025
View reviewed changes
Comment thread services/subscription-service/src/controllers/billing-payment-source.controller.ts Outdated
Tyagi-Sunny
Tyagi-Sunny reviewed Jun 25, 2025
View reviewed changes
Comment thread services/subscription-service/src/controllers/plan-features.controller.ts Outdated
Tyagi-Sunny
Tyagi-Sunny reviewed Jun 25, 2025
View reviewed changes
Comment thread services/subscription-service/src/services/subscription.service.ts Outdated
Tyagi-Sunny
Tyagi-Sunny reviewed Jun 25, 2025
View reviewed changes
Comment thread services/tenant-management-service/src/component.ts Outdated
Tyagi-Sunny
Tyagi-Sunny reviewed Jun 25, 2025
View reviewed changes
Comment thread services/tenant-management-service/src/sequelize-component.ts Outdated
@vaibhavbhalla2505
vaibhavbhalla2505 force-pushed the GH-88 branch 3 times, most recently from 0364e81 to 8e2939a Compare June 25, 2025 07:10
Tyagi-Sunny
Tyagi-Sunny reviewed Jul 4, 2025
View reviewed changes
Comment thread services/subscription-service/src/component.ts Outdated
@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.2% Duplication on New Code

See analysis details on SonarQube Cloud

yeshamavani
yeshamavani requested changes Oct 7, 2025
View reviewed changes
Comment thread services/subscription-service/src/controllers/billing-customer.controller.ts
@vaibhavbhalla2505
vaibhavbhalla2505 force-pushed the GH-88 branch 2 times, most recently from aa3581d to eafbf5b Compare October 8, 2025 07:56
@vaibhavbhalla2505
vaibhavbhalla2505 requested review from yeshamavani and removed request for akshatdubeysf October 8, 2025 07:58
Tyagi-Sunny
Tyagi-Sunny reviewed Oct 9, 2025
View reviewed changes
Comment thread services/tenant-management-service/src/controllers/lead.controller.ts Outdated
@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarQube Cloud

@yeshamavani
yeshamavani merged commit 27b4636 into master Oct 9, 2025
7 checks passed
@yeshamavani
yeshamavani deleted the GH-88 branch October 9, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yeshamavani yeshamavani yeshamavani approved these changes
@Tyagi-Sunny Tyagi-Sunny Tyagi-Sunny approved these changes
@a-ganguly a-ganguly Awaiting requested review from a-ganguly

Assignees

@vaibhavbhalla2505 vaibhavbhalla2505

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove extra code from service's controllers

3 participants

@vaibhavbhalla2505 @yeshamavani @Tyagi-Sunny