feat: add wrap_links option to render links as plain "text: href"#40
Merged
Merged
Conversation
… just use pure text
Review fixes on top of the original contribution: - simplify the redundant `!output.empty?` check (already guaranteed by the surrounding if-branch) - drop the write-only `attr_writer :wrap_links`; the value is consumed once during convert and `doc` only has a reader - revert the version bump — versioning happens at release time, and a new option is a minor bump, not a patch - add a CHANGELOG entry documenting the option and its scope (only `<a href>` links; images and named anchors keep their brackets) - move the spec out of the top of html2text_spec.rb's scope into its own spec/wrap_links_spec.rb, and cover the default format, the initializer path, linked images, empty link text, and href-equals- text/mailto cases alongside the original example Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mscrivo
changed the title
Collaborator
|
sorry @gusrub I just saw this today. Made some minor changes and committed, I'll release this as part of 0.5.0 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I'm not sure if you accept patches but I came across a specific need to have the links not wrapped and did some changes to the code.
Basically the gem turns links like this:
Into this:
We need to have a fully text-only version of certain html that we add for descriptions for calendar ICS integration and the markdown-like syntax kinda seems broken/off into said descriptions.
I added an optional
wrap_linksargument that defaults totrueso the existing implementation does not break for anyone but if you passfalseto the initializer or theconvertmethod then you would get something like this instead:Which suits or needs and probably others.
Also updated the SPEC's to include a test case for this.