Repository navigation
feat(integration): isolate CLI integration WASM artifacts for parallel tests - #372
Merged
0xsamuel1 merged 1 commit intoOct 20, 2026
Conversation
Build each limits test's vault.wasm into its own uniquely-named temp target dir (--target-dir) so parallel tests never race on a shared target/wasm32v1-none/release/vault.wasm. The IsolatedDir helper removes the temp dir and every artifact on drop, leaving no residue, and a new regression test asserts creation, use, and cleanup. This removes the cross-test dependency where the unknown-function test skipped unless the batch-payout test built the shared wasm first. Also fix a pre-existing coverage.rs compile error where the error format strings referenced an out-of-scope 'status' variable, which blocked building the soroban-testkit-cli bin (and therefore its integration tests) altogether. closes soroban-testkit#215
|
@francescoricc1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolate generated WASM artifacts in CLI integration tests so they can run in parallel.
Each limits test now builds vault into its own uniquely-named temp target
dir (cargo --target-dir) instead of a shared target/wasm32v1-none/release/vault.wasm,
removing the cross-test dependency (the unknown-function test previously
skipped unless the batch-payout test built the shared wasm first).
An IsolatedDir helper removes the temp dir and every artifact on drop,
verified by a new regression test asserting creation, use, and cleanup
(no residue left in the system temp dir).
Also fixes a pre-existing coverage.rs compile error (format strings
referenced an out-of-scope 'status' variable) that blocked building the
soroban-testkit-cli bin and therefore its integration tests.
Network-free behavior and error conventions are preserved; no new
dependencies added.
closes #215