Modernize#461
Conversation
Develop to master
release sora v3.8.6.0 119
release sora v3.8.6.1 120
release sora v3.8.6.2 121
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5cbf929fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pull_request: | ||
| branches: [ "*" ] | ||
| push: | ||
| branches: [ "*" ] |
There was a problem hiding this comment.
In .github/workflows/android_verification.yml, both the pull_request and push triggers are filtered with branches: [ "*" ], which does not mean “all branches” in GitHub Actions: the official workflow syntax docs state that * does not match /, while ** does. As a result, pushes to common branch names like feature/indexer-migration or release/3.8 will skip this verification workflow entirely, leaving the new live contract and connected tests unrun for those changes. See GitHub's filter pattern cheat sheet: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
Useful? React with 👍 / 👎.
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
3 participants
No description provided.