fix(zyra-eyes): add adaptive mouse-like smooth cursor engine - #69
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c7c5d04cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def set_paused(self, paused: bool) -> None: | ||
| with self.lock: | ||
| self.paused = bool(paused) |
There was a problem hiding this comment.
Resynchronize the actuator when resuming
When the operator moves the physical mouse while gaze control is paused, self.position retains the pre-pause coordinates. Resuming only clears this flag, so the next actuator tick issues a moveTo from that stale internal position, causing the pointer to jump back before moving toward the current gaze target. Read the actual pointer position and reset velocity when transitioning from paused to active.
Useful? React with 👍 / 👎.
| if motion is not None: | ||
| motion.set_paused(True) |
There was a problem hiding this comment.
Finish drag motion before pausing for the dock
When a user looks at a drop destination and then immediately enters the dock, the asynchronous actuator can still be approaching state.last_content_target; this pause freezes it at the lagging physical position. After the dock dwell, base.perform_command("DRAG", ...) handles an active drag by calling mouseUp() without moving to the supplied target, so the item is dropped at that stale position. Synchronize the actuator to the last content target before pausing or explicitly move there before releasing the drag.
Useful? React with 👍 / 👎.
ZYRA Eyes mouse-smoothness fix
The current full controller updates the pointer at gaze/camera-frame cadence using fixed EMA smoothing and a hard pixel deadzone, which creates visible stepping and lag.
Fix
zyra_smooth_controller.pyBoundary
This remains a local accessibility controller. Demo mode is default. Native control still requires the existing owner sentinel plus
--native --approve; no remote-control server or hidden network channel is added.Important sensor limit
The high-rate actuator makes cursor motion visually continuous between webcam samples, but it does not turn a 30–60 fps webcam into a dedicated high-rate infrared eye tracker. Accuracy still depends on calibration, pupil visibility, lighting, camera placement, and head stability.