Extend VIRGINIA with mission telemetry and brain update syntax - #51
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| export function parseVirginia(input: string): VirginiaMission { | ||
| const lines = input.split(/\r?\n/).map((line) => line.trim()).filter(Boolean); | ||
| const rawSegments = input.includes("///") ? input.split(/\s*\/\/\/\s*/) : [input]; |
| steps.push({ op: "SPACEX_LAUNCHES", text: "read-only public SpaceX API data" }); | ||
| continue; | ||
| } | ||
| const fprimeTelemetry = line.match(/^FPRIME\s+TELEMETRY(?:\s+(.+))?$/i); |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 504a6c3b90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| continue; | ||
| } | ||
| if (/^MISSION\s+TWIN\s+STATUS$/i.test(line)) { | ||
| steps.push({ op: "MISSION_TWIN_STATUS" }); |
There was a problem hiding this comment.
When any of the new telemetry commands is submitted to POST /api/virginia/execute, the parser emits these operations, but executeStep() in server.ts has no corresponding cases and therefore sends every one through its default note response. Consequently MISSION TWIN STATUS returns an empty note, while the SpaceX and F´ commands merely echo their descriptive text without reading any telemetry, so the newly advertised read operations never execute.
Useful? React with 👍 / 👎.
|
|
||
| export function parseVirginia(input: string): VirginiaMission { | ||
| const lines = input.split(/\r?\n/).map((line) => line.trim()).filter(Boolean); | ||
| const rawSegments = input.includes("///") ? input.split(/\s*\/\/\/\s*/) : [input]; |
There was a problem hiding this comment.
When a valid source URL contains /// in its path, such as BRAIN UPDATE https://example.com/a///b, this pre-processing splits the URL before the explicit command is parsed. The resulting mission records the truncated https://example.com/a source and turns b into a separate NOTE, silently changing the requested source; delimiter recognition should be constrained so it cannot match characters within a URL.
Useful? React with 👍 / 👎.
2 participants
Extends the VIRGINIA parser with mission-twin read operations for SpaceX public data and F´ simulation telemetry. Adds
///as a brain-update source delimiter for URL knowledge sources, plus explicitBRAIN UPDATE <url>syntax. These source updates grant no execution authority. Includes parser tests and preserves existing VA3LM/RICHMONDVA3LM behavior.