Repository navigation
feat(web): add pepito (Vanguard.tf) testimonial to the landing page - #359
Merged
Merged
Conversation
Add a seventh testimonial to the quickserver.tf carousel for pepito, founder of Vanguard.tf, reproduced verbatim with his three paragraphs kept intact rather than collapsed into one run-on block. The avatar is vendored to public/avatars/pepito.jpg because the static export disables next/image optimization and forbids external image domains. Render one <p> per paragraph through an exported toParagraphs helper that normalizes a string or a string[]; the six existing single-paragraph entries degenerate to their previous markup byte-for-byte, verified against a pre-change build.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pepito (Vanguard.tf) testimonial to the landing page
Summary
Adds a seventh community testimonial to the quickserver.tf "What Players Say" carousel, for
pepito, founder of Vanguard.tf — the South American PUG/mix community. His testimonial is
reproduced verbatim and keeps the three paragraphs he wrote.
The avatar is vendored into the repository because the landing page is a static Next.js export with
images.unoptimized: true, sonext/imagecannot reference an external domain here.Key changes
packages/web/public/avatars/pepito.jpg(new) — pepito's Steam avatar, downloaded from hisSteam profile (6,201 bytes, 184×184 JPEG, byte-identical to the source).
packages/web/src/components/testimonials.tsxTestimonialtype and theTESTIMONIALSarray so the data is testable.toParagraphs(testimonial)that normalizes astringor areadonly string[]into areadonly string[].<p>per paragraph instead of a single<p>, with the opening curly quote on thefirst paragraph and the closing quote on the last, and
mt-3between paragraphs.packages/web/src/components/testimonials.test.ts(new) — coverstoParagraphs, pepito'sentry and title/avatar, the verbatim text paragraph by paragraph, unique
playerkeys (they areReact keys), and that every referenced avatar file exists under
packages/web/public.Nothing else changed: no new dependency, no change to the card layout, the scroll buttons, the
other six testimonials,
navbar.tsx,page.tsx,next.config.ts, or any workflow.Why the render changed at all
The previous single
<p>collapsed the author's paragraph breaks into one run-on block. The changeis deliberately minimal so the six existing single-paragraph entries are unaffected: for a
string,toParagraphsreturns a one-element array, so the first and last paragraph are the same element andthe markup degenerates to exactly the previous output. This was verified by diffing the rendered card
markup against a pre-change build — all six existing cards are byte-identical, including React's
<!-- -->text-node separators.Testing
npm test— 839 tests / 116 files pass, including the 7 new tests.npm run build:web— succeeds, including its TypeScript pass.Note:
npm run build:backenddoes not typecheck this package — the roottsconfig.jsonexcludes
packages/web/**— sobuild:webis the web typecheck.out/avatars/pepito.jpg.is an accepted, cosmetic consequence of keeping the testimonial in full; it is revertible by
trimming the text.
Related
No issue — requested directly.
Produced in Autonomous Loop mode. The local loop (implement → independent review → fix) completed
with no Critical or Major findings outstanding. Awaiting human review — not to be merged without
it.