[dashha]: Acknowledge switch-owned HA switching_to_active - #4820
Open
zjswhhh wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jing Zhang <zhangjing@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
zjswhhh
changed the title
zjswhhh
changed the title
switching_to_active
zjswhhh
marked this pull request as draft
August 7, 2026 00:56
zjswhhh
marked this pull request as ready for review
August 7, 2026 04:18
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
vivekrnv
approved these changes
Aug 7, 2026
Contributor
|
Validated this change and is working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Map
HA_ROLE_SWITCHING_TO_ACTIVEtoSAI_DASH_HA_STATE_INITIALIZING_TO_ACTIVEfor switch-owned HA scopes.Keep the existing non-dead transition behavior so cached software BFD sessions are created when the scope starts switching to active. Add focused mock coverage for the state, role, and BFD invocation.
Why I did it
Switch-owned HA scopes do not rely on HA scope notifications to acknowledge role transitions. The existing code returned without updating
DPU_STATE_DBor the in-memory state forHA_ROLE_SWITCHING_TO_ACTIVE, leaving the transition unacknowledged.How I verified it
orchagentbinary successfully.git diff --checkpassed.