[orchagent]: Extend syncd response timeout for APPLY_VIEW - #4818
Draft
YairRaviv wants to merge 1 commit into
Draft
[orchagent]: Extend syncd response timeout for APPLY_VIEW#4818YairRaviv wants to merge 1 commit into
YairRaviv wants to merge 1 commit into
Conversation
Signed-off-by: Yair Raviv <yraviv@nvidia.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Extended the SAI-Redis sync operation response timeout around
APPLY_VIEWinsyncd_apply_view(), matching the existing long timeout used forINIT_VIEW, then restored the default 60s timeout afterward.Moved
SAI_REDIS_SYNC_OPERATION_RESPONSE_TIMEOUTfromsaihelper.cpptosaihelper.hso bothinitSaiRedis()andsyncd_apply_view()can share it.Why I did it
During warm reboot at large route / full-KVD scale, syncd's
APPLY_VIEW(view comparison + full ASIC_DB rewrite) can take longer than the default 60s SAI-Redis response timeout (observed ~88s). orchagent then fails the notify and aborts warm reboot even though syncd is still progressing.How I verified it
Warm reboot at high route scale on a build with this change
Details if related