[portsorch] Skip default VLAN and bridge port removal during warm restart - #4801
Open
haojun291 wants to merge 1 commit into
Open
[portsorch] Skip default VLAN and bridge port removal during warm restart#4801haojun291 wants to merge 1 commit into
haojun291 wants to merge 1 commit into
Conversation
…tart Signed-off-by: zhonghaojun <young@micasnetworks.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Skipped removeDefaultVlanMembers() and removeDefaultBridgePorts() during warm restart in the PortsOrch constructor.
Why I did it
During a warm restart, the underlying ASIC state is preserved, and these ports have already been removed from the default VLAN and bridge during the initial cold boot. Redundantly calling these remove functions causes SAI validation errors (e.g., reference count is 1, can't remove).
How I verified it
Performed warm reboot.
Details if related
