refactor: replace raw pointer with unique_ptr in NotificationConsumer by xq9mend · Pull Request #1212 · sonic-net/sonic-swss-common

xq9mend · 2026-06-19T07:41:57Z

What

Replace raw DBConnector* member m_subscribe with std::unique_ptr<DBConnector> in NotificationConsumer.

Why

The raw pointer required manual delete in two separate places — the destructor and the constructor catch block. This pattern is error-prone and exception-unsafe: if a future change adds an early return or throws between allocation and cleanup, the pointer leaks.

How

Remove explicit destructor — compiler-generated handles cleanup via unique_ptr
Remove delete m_subscribe from catch block — automatic on reassignment
Remove NULL initializer — unique_ptr default-constructs to nullptr
Replace new DBConnector(...) with std::make_unique<DBConnector>(...) in subscribe()
Add .get() where raw pointer is passed to RedisReply constructor
Add <memory> include to both .cpp and .h

mssonicbld · 2026-06-19T07:42:05Z

/azp run

azure-pipelines · 2026-06-19T07:42:12Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2026-06-19T07:46:14Z

/azp run

azure-pipelines · 2026-06-19T07:46:26Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-19T20:35:58Z

/azp run

azure-pipelines · 2026-06-19T20:36:11Z

Azure Pipelines successfully started running 1 pipeline(s).

xq9mend · 2026-06-20T07:07:27Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2026-06-20T07:13:22Z

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

mssonicbld · 2026-06-20T07:13:25Z

No Azure DevOps builds found for #1212.

mssonicbld · 2026-06-20T07:13:26Z

/azp run

azure-pipelines · 2026-06-20T07:13:39Z

Azure Pipelines successfully started running 1 pipeline(s).

xq9mend · 2026-06-20T09:20:49Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2026-06-20T09:20:51Z

/azp run

mssonicbld · 2026-06-20T09:20:52Z

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

mssonicbld · 2026-06-20T09:20:53Z

No Azure DevOps builds found for #1212.

azure-pipelines · 2026-06-20T09:21:02Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-20T11:20:20Z

Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks!

_{---Powered by SONiC BuildBot}

xq9mend · 2026-06-20T14:41:44Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2026-06-20T14:41:47Z

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

mssonicbld · 2026-06-20T14:41:49Z

Retrying failed(or canceled) stages in build 1144141:

✅Stage BuildSairedis:

Job amd64: retried.

xq9mend · 2026-06-21T00:43:51Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2026-06-21T00:43:53Z

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

mssonicbld · 2026-06-21T00:43:56Z

Retrying failed(or canceled) stages in build 1144141:

✅Stage BuildSwss:

Job amd64: retried.

xq9mend · 2026-07-04T09:47:02Z

/azp run Azure.sonic-swss-common

azure-pipelines · 2026-07-04T09:47:08Z

Commenter does not have sufficient privileges for PR 1212 in repo sonic-net/sonic-swss-common

qiluo-msft · 2026-08-06T06:58:41Z

/azp run Azure.sonic-swss-common

azure-pipelines · 2026-08-06T06:58:56Z

Azure Pipelines: Successfully started running 1 pipeline(s).

m_subscribe was a raw DBConnector* requiring manual delete in two places: the destructor and the constructor's catch block. This is error-prone and exception-unsafe. Replace with std::unique_ptr<DBConnector>: - Remove explicit destructor (compiler-generated handles cleanup) - Remove delete in catch block (reset is automatic on reassignment) - Remove NULL initializer (unique_ptr default-constructs to nullptr) - Use std::make_unique<DBConnector>() in subscribe() - Add .get() where raw pointer is passed to RedisReply constructor Test: add SubscribeViaUnixSocket to ntf_ut.cpp to cover the unix-socket branch of subscribe() (all previous tests used TCP connections). Signed-off-by: xq9mend <xq9mend@users.noreply.github.com>

mssonicbld · 2026-08-07T21:28:55Z

/azp run

azure-pipelines · 2026-08-07T21:29:09Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

Pull request overview

Refactors NotificationConsumer subscription ownership to use RAII and adds Unix-socket coverage.

Changes:

Replaces raw DBConnector* ownership with std::unique_ptr.
Removes manual deletion and uses std::make_unique.
Tests Unix-socket notification subscription.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`common/notificationconsumer.h`	Defines unique ownership and default cleanup.
`common/notificationconsumer.cpp`	Implements automatic connector allocation and cleanup.
`tests/ntf_ut.cpp`	Verifies Unix-socket subscription and delivery.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

xq9mend force-pushed the fix/notificationconsumer-unique-ptr branch from 9a9cadf to 8ab7f45 Compare June 19, 2026 07:46

xq9mend force-pushed the fix/notificationconsumer-unique-ptr branch from 8ab7f45 to 54bb184 Compare June 19, 2026 20:35

xq9mend mentioned this pull request Jun 19, 2026

fix: replace NULL with nullptr in fake_notificationconsumer constructors sonic-net/sonic-swss#4686

Merged

xq9mend force-pushed the fix/notificationconsumer-unique-ptr branch from 54bb184 to 1ee2c80 Compare June 20, 2026 07:04

xq9mend force-pushed the fix/notificationconsumer-unique-ptr branch from 1ee2c80 to ccfec8b Compare June 20, 2026 09:20

This was referenced Jun 21, 2026

fix: use fgets return value as loop condition in exec() #1211

Open

perf: eliminate redundant map lookups in swssPrioNotify and swssOutputNotify #1214

Open

xq9mend force-pushed the fix/notificationconsumer-unique-ptr branch from ccfec8b to b5b4c90 Compare August 7, 2026 21:28

qiluo-msft requested a balanced review from Copilot August 8, 2026 00:51

Copilot started reviewing on behalf of qiluo-msft August 8, 2026 00:52 View session

Copilot AI reviewed Aug 8, 2026

View reviewed changes

Uh oh!

Conversation

xq9mend commented Jun 19, 2026

What

Why

How

Uh oh!

mssonicbld commented Jun 19, 2026

Uh oh!

azure-pipelines Bot commented Jun 19, 2026

Uh oh!

mssonicbld commented Jun 19, 2026

Uh oh!

azure-pipelines Bot commented Jun 19, 2026

Uh oh!

mssonicbld commented Jun 19, 2026

Uh oh!

azure-pipelines Bot commented Jun 19, 2026

Uh oh!

xq9mend commented Jun 20, 2026

Uh oh!

mssonicbld commented Jun 20, 2026

Uh oh!

mssonicbld commented Jun 20, 2026

Uh oh!

mssonicbld commented Jun 20, 2026

Uh oh!

azure-pipelines Bot commented Jun 20, 2026

Uh oh!

xq9mend commented Jun 20, 2026

Uh oh!

mssonicbld commented Jun 20, 2026

Uh oh!

mssonicbld commented Jun 20, 2026

Uh oh!

mssonicbld commented Jun 20, 2026

Uh oh!

azure-pipelines Bot commented Jun 20, 2026

Uh oh!

mssonicbld commented Jun 20, 2026

Uh oh!

xq9mend commented Jun 20, 2026

Uh oh!

mssonicbld commented Jun 20, 2026

Uh oh!

mssonicbld commented Jun 20, 2026

Uh oh!

xq9mend commented Jun 21, 2026

Uh oh!

mssonicbld commented Jun 21, 2026

Uh oh!

mssonicbld commented Jun 21, 2026

Uh oh!

xq9mend commented Jul 4, 2026

Uh oh!

azure-pipelines Bot commented Jul 4, 2026

Uh oh!

qiluo-msft commented Aug 6, 2026

Uh oh!

azure-pipelines Bot commented Aug 6, 2026

Uh oh!

mssonicbld commented Aug 7, 2026

Uh oh!

azure-pipelines Bot commented Aug 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants