Skip to content

[action] [PR:1087] Fix mocktests for buster builds - #1171

Open
mssonicbld wants to merge 1 commit into
sonic-net:202511from
mssonicbld:cherry/202511/1087
Open

[action] [PR:1087] Fix mocktests for buster builds#1171
mssonicbld wants to merge 1 commit into
sonic-net:202511from
mssonicbld:cherry/202511/1087

Conversation

@mssonicbld

Copy link
Copy Markdown
Collaborator
   tests/zmq_state_ut.cpp:698:25: error: expected constructor, destructor, or type conversion before '(' token INSTANTIATE_TEST_SUITE_P( ^ tests/zmq_state_ut.cpp:702:56: error: expected unqualified-id before ',' token
         PopSizeTestParams{40, 150, 4, {40, 40, 40, 30}},
                                                        ^
tests/zmq_state_ut.cpp:703:26: error: expected constructor, destructor, or type conversion before '{' token
         PopSizeTestParams{-1, 384, 3, {128, 128, 128}}
                          ^
tests/zmq_state_ut.cpp:704:5: error: expected unqualified-id before ')' token
     )
     ^
make[4]: *** [Makefile:2683: tests/tests-zmq_state_ut.o] Error 1

Signed-off-by: Sonic Build Admin sonicbld@microsoft.com

 * PTF build still uses buster which does not support INSTANTIATE_TEST_SUITE_P. This change fixes the error below related to sonic-net#1084

```
   tests/zmq_state_ut.cpp:698:25: error: expected constructor, destructor, or type conversion before '(' token INSTANTIATE_TEST_SUITE_P( ^ tests/zmq_state_ut.cpp:702:56: error: expected unqualified-id before ',' token
         PopSizeTestParams{40, 150, 4, {40, 40, 40, 30}},
                                                        ^
tests/zmq_state_ut.cpp:703:26: error: expected constructor, destructor, or type conversion before '{' token
         PopSizeTestParams{-1, 384, 3, {128, 128, 128}}
                          ^
tests/zmq_state_ut.cpp:704:5: error: expected unqualified-id before ')' token
     )
     ^
make[4]: *** [Makefile:2683: tests/tests-zmq_state_ut.o] Error 1
```

Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator Author

Original PR: #1087

@mssonicbld

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator Author

This cherry pick PR has been opened for more than 3 days. The mssonicbld will attempt to retry.

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown
Collaborator Author

/azpw retry

@mssonicbld

Copy link
Copy Markdown
Collaborator Author

Retrying failed(or canceled) jobs...

@mssonicbld

Copy link
Copy Markdown
Collaborator Author

Retrying failed(or canceled) stages in build 1080498:

✅Stage Test:

  • Job vstest: retried.

@mssonicbld

Copy link
Copy Markdown
Collaborator Author

@vmittal-msft The cherry pick PR didn't pass PR checker after retry. Left a comment in original PR #1087 to notify author.

---Powered by SONiC BuildBot

@prabhataravind

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vmittal-msft

Copy link
Copy Markdown

@prabhataravind can you please help fix for 202511 if this is needed as we are close to release

@vmittal-msft

Copy link
Copy Markdown

@prabhataravind please help check failures so we can include for 202511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants