Skip to content

Fix Y2038 time_t usage in syncd and vslib - #2026

Open
subharam-cisco wants to merge 2 commits into
sonic-net:masterfrom
subharam-cisco:fix/y2038-time-handling
Open

Fix Y2038 time_t usage in syncd and vslib#2026
subharam-cisco wants to merge 2 commits into
sonic-net:masterfrom
subharam-cisco:fix/y2038-time-handling

Conversation

@subharam-cisco

Copy link
Copy Markdown

Use std::random_device instead of std::time(0) for srand seeding in ComparisonLogic. Add FdbInfo::currentEpochTimeSec() to safely clamp 64-bit epoch time to uint32_t for FDB aging and packet timestamps.

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation update
  • Test improvement

Approach

What is the motivation for this PR?

Work item tracking
  • Microsoft ADO (number only):

How did you do it?

How did you verify/test it?

Any platform specific information?

Documentation

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 7, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: subharam-cisco / name: Subhasri-Ramasamy (ab5f237)

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks!

---Powered by SONiC BuildBot

Signed-off-by: Subhasri-Ramasamy <subharam@cisco.com>
@subharam-cisco
subharam-cisco force-pushed the fix/y2038-time-handling branch from cecc188 to ab5f237 Compare August 7, 2026 07:15
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

…the required SWSS_LOG_ENTER() macro to the Y2038 helper added in vslib.

Signed-off-by: Subhasri-Ramasamy <subharam@cisco.com>
@subharam-cisco
subharam-cisco force-pushed the fix/y2038-time-handling branch from 6d16a40 to 6f59c32 Compare August 10, 2026 06:51
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants