Manual cast new syncd arg logic from master to 202605 (#2000) - #2021
Draft
justin-wong-ce wants to merge 1 commit into
Draft
Manual cast new syncd arg logic from master to 202605 (#2000)#2021justin-wong-ce wants to merge 1 commit into
justin-wong-ce wants to merge 1 commit into
Conversation
Casting from: sonic-net#2000 Signed-off-by: Justin Wong <jvwong@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
5 tasks
Contributor
Author
|
Will makr PR as active when CI passes. |
Contributor
Author
|
/azpw retry |
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
Retrying failed(or canceled) stages in build 1184108: ✅Stage Build:
✅Stage BuildAsan:
|
Contributor
Author
|
Weird, I can't reproduce the unit test failure locally. Need to take a further look. |
Contributor
Author
|
/azpw retry |
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
Retrying failed(or canceled) stages in build 1184108: ✅Stage Build:
✅Stage BuildAsan:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual casting PR #2000 from master to 202605 due to cherry-pick conflicts.
Description of PR
Summary:
Add an argument to
syncdto toggle between the new per-port counter discovery feature inFlexCounteror to use the legacy method.This is a part 1 of 2 fix in addressing sonic-net/sonic-buildimage#28460. There are two fix methods under consideration, this part is generic to both methods.
Fixes # (issue)
Partially Fixes sonic-net/sonic-buildimage#28460
Needs backport to 202605.
Type of change
Approach
What is the motivation for this PR?
In #1774 , a new counter support discovery method is introduced for being able to read counter support for platforms where different ports can have different capabilities.
The method worked well for some platforms, not so much for some others.
This change adds an argument to
syncdso there is the capability to toggle the per-port counter discovery. The argument will default tofalseso the legacy code path is used by default.Since there is now an option to toggle the code path on or off, there is no longer a need for a runtime fallback.
Work item tracking
How did you do it?
Add an argument to
syncdas well as the logic needed to read the argument in various files insyncd.Unit tests are also updated to account for the new argument, as well as mocking the use of this argument for unit tests that only test for per-port discovery logic.
How did you verify/test it?
Unit tests passes on both master and with the change casted to 202605.
syncdis also able to boot on physical hardware and enter the expected code path based on whether the argument was provided for launch or not.Any platform specific information?
Generic
Documentation