Skip to content

Toggle enablePerPortCounterDiscovery based on HWSKU config #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lolyu merged 2 commits into from
Aug 6, 2026
Merged

Toggle enablePerPortCounterDiscovery based on HWSKU config #2002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d9100e
Add per-port counter discovery toggling based on CONFIG_DB
justin-wong-ce Jul 19, 2026
2745b39
Merge branch 'master' into genFix-confdb
justin-wong-ce Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions syncd/scripts/syncd_init_common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,16 @@ if [ "$SUPPORTING_BULK_COUNTER_GROUPS" != "" ]; then
CMD_ARGS+=" -B $SUPPORTING_BULK_COUNTER_GROUPS"
fi

# Enable per-port counter capability discovery (see sonic-buildimage#28460, #1774).
# Add ASIC types that needs this feature here
case "$SONIC_ASIC_TYPE" in
broadcom)
CMD_ARGS+=" -G"
;;
esac
ENABLE_PER_PORT_COUNTER_DISCOVERY=$(echo $SYNCD_VARS | jq -r 'if has("enable_per_port_counter_discovery") then .enable_per_port_counter_discovery else "" end')
if [ "$ENABLE_PER_PORT_COUNTER_DISCOVERY" == "true" ]; then
CMD_ARGS+=" -G"
elif [ -z "$ENABLE_PER_PORT_COUNTER_DISCOVERY" ]; then
case "$SONIC_ASIC_TYPE" in
broadcom)
CMD_ARGS+=" -G"
;;
esac
fi

case "$(cat /proc/cmdline)" in
*SONIC_BOOT_TYPE=fastfast*)
Expand Down
Loading