Skip to content

Set fabric port defaults for vs platform #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lakshmi-nexthop wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −0
Open

Set fabric port defaults for vs platform #1998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions unittest/vslib/TestSwitchStateBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,24 @@ TEST_F(SwitchStateBaseTest, switchQoSMaxNumOfTrafficClasses)
ASSERT_EQ(attr.value.u8, maxTcNum);
}

TEST_F(SwitchStateBaseTest, switchFabricPortDefaults)
{
ASSERT_EQ(m_ss->set_switch_default_attributes(), SAI_STATUS_SUCCESS);

// A switch without a fabric lane map must report 0 fabric ports rather than
// SAI_STATUS_NOT_IMPLEMENTED, matching hardware on a fabric-less box.
sai_attribute_t attr;
attr.id = SAI_SWITCH_ATTR_NUMBER_OF_FABRIC_PORTS;
ASSERT_EQ(m_ss->get(SAI_OBJECT_TYPE_SWITCH, sai_serialize_object_id(m_swid), 1, &attr), SAI_STATUS_SUCCESS);
ASSERT_EQ(attr.value.u32, 0U);

attr.id = SAI_SWITCH_ATTR_FABRIC_PORT_LIST;
attr.value.objlist.count = 0;
attr.value.objlist.list = nullptr;
ASSERT_EQ(m_ss->get(SAI_OBJECT_TYPE_SWITCH, sai_serialize_object_id(m_swid), 1, &attr), SAI_STATUS_SUCCESS);
ASSERT_EQ(attr.value.objlist.count, 0U);
}

TEST_F(SwitchStateBaseTest, processFipsPostConfig)
{
std::ofstream post_config_file(VS_SAI_FIPS_POST_CONFIG_FILE);
Expand Down
14 changes: 14 additions & 0 deletions vslib/SwitchStateBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,6 +1196,20 @@ sai_status_t SwitchStateBase::set_switch_default_attributes()

CHECK_STATUS(set(SAI_OBJECT_TYPE_SWITCH, m_switch_id, &attr));

// Default to no fabric ports so a GET returns 0 rather than
// SAI_STATUS_NOT_IMPLEMENTED. Switches with a fabric lane map overwrite
// these in set_fabric_port_list().
attr.id = SAI_SWITCH_ATTR_NUMBER_OF_FABRIC_PORTS;
attr.value.u32 = 0;

CHECK_STATUS(set(SAI_OBJECT_TYPE_SWITCH, m_switch_id, &attr));

attr.id = SAI_SWITCH_ATTR_FABRIC_PORT_LIST;
attr.value.objlist.count = 0;
attr.value.objlist.list = nullptr;

CHECK_STATUS(set(SAI_OBJECT_TYPE_SWITCH, m_switch_id, &attr));

return set_switch_supported_object_types();
}

Expand Down
Loading