[syncd]: Route FDB LEARN/AGED/MOVE events via ProducerStateTable for key-based dedup - #1875
Open
xq9mend wants to merge 6 commits into
Open
[syncd]: Route FDB LEARN/AGED/MOVE events via ProducerStateTable for key-based dedup#1875xq9mend wants to merge 6 commits into
xq9mend wants to merge 6 commits into
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
xq9mend
force-pushed
the
fix/fdb-producer-state-table
branch
from
April 29, 2026 20:24
ae644aa to
6237b5b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xq9mend
added a commit
to xq9mend/sonic-buildimage
that referenced
this pull request
Apr 30, 2026
…able Update src/sonic-sairedis to ae644aa9: Route FDB LEARN/AGED/MOVE events via ProducerStateTable for key-based dedup Update src/sonic-swss to 50abedff: Consume FDB LEARN/AGED/MOVE events from ProducerStateTable Related PRs: sonic-sairedis: sonic-net/sonic-sairedis#1875 sonic-swss: sonic-net/sonic-swss#4533 Signed-off-by: xq9mend <xq9mend@users.noreply.github.com>
xq9mend
force-pushed
the
fix/fdb-producer-state-table
branch
from
April 30, 2026 05:51
e4bc7b4 to
050ed30
Compare
Collaborator
|
/azp run |
xq9mend
added a commit
to xq9mend/sonic-buildimage
that referenced
this pull request
Apr 30, 2026
…able Update src/sonic-sairedis to ae644aa9: Route FDB LEARN/AGED/MOVE events via ProducerStateTable for key-based dedup Update src/sonic-swss to 50abedff: Consume FDB LEARN/AGED/MOVE events from ProducerStateTable Related PRs: sonic-sairedis: sonic-net/sonic-sairedis#1875 sonic-swss: sonic-net/sonic-swss#4533 Signed-off-by: xq9mend <xq9mend@users.noreply.github.com>
|
Azure Pipelines successfully started running 1 pipeline(s). |
xq9mend
force-pushed
the
fix/fdb-producer-state-table
branch
from
April 30, 2026 06:20
050ed30 to
149b97a
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xq9mend
force-pushed
the
fix/fdb-producer-state-table
branch
from
April 30, 2026 07:29
149b97a to
18b9014
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xq9mend
force-pushed
the
fix/fdb-producer-state-table
branch
from
April 30, 2026 21:16
18b9014 to
ebf146d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xq9mend
force-pushed
the
fix/fdb-producer-state-table
branch
from
May 4, 2026 05:43
28f9fea to
83b97d2
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xq9mend
force-pushed
the
fix/fdb-producer-state-table
branch
from
May 7, 2026 17:50
83b97d2 to
4b213de
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Split FDB notification handling in NotificationProcessor: - FLUSH events continue via PUBLISH/NotificationProducer (existing path) - LEARN/AGED/MOVE events use ProducerStateTable (key-based dedup) ProducerStateTable provides MAC-keyed deduplication so rapid flap storms for the same MAC+BVID collapse to one entry instead of flooding the notification queue. Fallback to PUBLISH is retained when m_fdbEventStateProducer is null (ZeroMQ mode). Adds REDIS_TABLE_FDB_EVENT_STATE define in sairediscommon.h. Passes m_dbAsic to NotificationProcessor constructor from Syncd. Signed-off-by: xq9mend <xq9mend@users.noreply.github.com>
…essor Cover the three new code paths added in process_on_fdb_event: - FdbLearnGoesToProducerStateTable: LEARN event writes to _FDB_EVENT_STATE:key - FdbAgedDeletesFromProducerStateTable: AGED event deletes the scratch key - FdbFlushDoesNotWriteToProducerStateTable: FLUSH event goes via PUBLISH Each test creates a NotificationProcessor with dbAsic to initialize m_fdbEventStateProducer, then verifies the Redis state after syncProcessNotification(). Signed-off-by: xq9mend <xq9mend@users.noreply.github.com>
xq9mend
force-pushed
the
fix/fdb-producer-state-table
branch
from
June 17, 2026 01:36
4b213de to
7a4a5b8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… tests Replace per-key del calls with dbAsic->flushdb() at the end of each new NotificationProcessor test. This ensures the entire ASIC_DB is clean after our tests run, preventing any Redis state pollution that could affect FlexCounter or other tests running in the same process. Signed-off-by: xq9mend <xq9mend@users.noreply.github.com>
xq9mend
force-pushed
the
fix/fdb-producer-state-table
branch
from
June 23, 2026 04:04
7a4a5b8 to
7ecf93f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
Retrying failed(or canceled) stages in build 1146339: ✅Stage BuildTrixie:
✅Stage Test:
|
Contributor
Author
|
CI status: All checks pass except This PR routes FDB LEARN/AGED/MOVE events via ProducerStateTable and is code-complete. Requesting a merge bypass given the known-broken vstest infra. CC @lolyu @croos12 @prsunny @Ndancejic |
Signed-off-by: xq9mend <xq9mend@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Signed-off-by: xq9mend <xq9mend@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Signed-off-by: xq9mend <xq9mend@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route FDB LEARN/AGED/MOVE events via ProducerStateTable for key-based dedup.
Adds REDIS_TABLE_FDB_EVENT_STATE define in sairediscommon.h. Passes m_dbAsic to NotificationProcessor constructor from Syncd.
FLUSH events continue via PUBLISH/NotificationProducer (existing path). LEARN/AGED/MOVE events use ProducerStateTable (key-based dedup). ProducerStateTable provides MAC-keyed deduplication so rapid flap storms for the same MAC+BVID collapse to one entry instead of flooding the notification queue.
Fallback to PUBLISH is retained when m_fdbEventStateProducer is null (ZeroMQ mode).