[vpp] add ipinip tunnel encap/decap support - #1860
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
left a comment
lolyu
left a comment
There was a problem hiding this comment.
✅ Review — Solid IPinIP Implementation
Matches the HLD (PR #222) exactly. Both decap (P2MP/P2P via tunnel term) and encap (P2P via tunnel nexthop) paths implemented with shared create_ipip_vpp_tunnel / remove_ipip_vpp_tunnel helpers. Clean error handling with partial-failure cleanup, VRF-aware with resolve_vrf_id / resolve_vrf_from_rif, proper get_tunnel_if fallthrough from VxLAN to IPIP.
Minor: verify that encap outer dst IP comes from tunnel object's ENCAP_DST_IP (not nexthop's SAI_NEXT_HOP_ATTR_IP) — the nexthop IP is the inner destination for MuxOrch.
LGTM 🚀
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
changed the title
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
VPP test sonic-buildimage PR: sonic-net/sonic-buildimage#27555, all vpp tests pass. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pr is merged a little bit too early. sonic-net/sonic-platform-vpp#226 is merged but not released. PR sonic-net/sonic-platform-vpp#225 will do that but it is pending on the sanity result. We may see compilation error until the latter is merged and updated in sonic-buildimage |
4 participants
Add VPP ipinip tunnel encap/decap support.
Please refer to HLD to design details: sonic-net/sonic-platform-vpp#222.
Signed-off-by: Longxiang Lyu lolv@microsoft.com