Fix p2mp tunnel - #221
Closed
lolyu wants to merge 2 commits into
Closed
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@lolyu thanks for the contribution. Can you please create a PR in fd.io? We normally submit the change to fd.io upstream unless it is some change not interested to the community, for example, the tunnel term ACL plugin is committed to sonic-vpp only. |
Contributor
|
I saw you already created PR in fd.io. Please follow through with it. |
Contributor
Author
Hi @yue-fred-gao, I don't plan to upstream this change to fd.io, as it is a hacky adaptation to VPP to allow SONiC-favored P2MP tunnel decap behavior, please check the HLD here for more details: #222, section 8. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
/azp run |
1 similar comment
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
lolyu
marked this pull request as ready for review
April 28, 2026 06:55
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to adapt VPP P2MP to have the same behavior as SAI P2MP (accept IPinIP packets with any source IP).
Please refer to this HLD for more details: #222
Signed-off-by: Longxiang Lyu lolv@microsoft.com