[CPO] Add ChassisBase hook for ELSFP presence - #733
Open
bgallagher-nexthop wants to merge 1 commit into
Open
Conversation
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
bgallagher-nexthop
marked this pull request as ready for review
August 6, 2026 18:43
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
aditya-nexthop
approved these changes
Aug 6, 2026
Comment on lines
+37
to
+38
| [chassis.get_elsfp_change_event, [], {}], | ||
| [chassis.get_elsfp_change_event, [1000], {}], |
Contributor
There was a problem hiding this comment.
do we need to add get_change_event here as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As described in the
xcvrdCPO HLD (see section 7.3.2.2 Presence Change Event Handling), a new hook to notify xcvrd of ELSFP insertion/removal events is required for CPO hardware.Motivation and Context
In
xcvrd, there will be a dedicated CPO task to react to ELSFP insertion and removal. It cannot re-use the existingget_change_eventAPI since that would cause events for traditional pluggable ports to be consumed by the CPO task and vice-versa.How Has This Been Tested?
Relying on unit-tests. This PR does not add any meaningful logic, just an unimplemented stub for vendors to implement.