Added C-CMIS PM API logic and advertisement - #715
Closed
nkanchi-nexthop wants to merge 2 commits into
Closed
Conversation
Signed-off-by: nkanchi-nexthop <nkanchi@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This was referenced Jul 16, 2026
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CCmisApi.get_pm_all()/get_transceiver_pm()so the newly-added Page 35h monitors are only read when the module advertises them as implemented.34hraw counters are used to derive PM fields that populate the dict. Now added the raw counters from34hinto the dict as well.Motivation and Context
The C-CMIS 1.4 spec marks Page
34hand35hmonitors as optional and gates them behind Page 42h advertisement bits. The original Page 34h/35h fields are left ungated since existing consumers depend on those keys always being populated. Only the new fields added need the new advertisement check.Page 3Ah counters have no corresponding Page 42h advertisement in the spec, so they're always read.
How Has This Been Tested?
tests/sonic_xcvr/test_ccmis.py.