Test_Passive_Peering - T2 Update - #26896
Open
sresri2 wants to merge 2 commits into
Open
Conversation
Signed-off-by: sresri2 <125845681+sresri2@users.noreply.github.com>
Signed-off-by: sresri2 <125845681+sresri2@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
github-actions
Bot
requested review from
cyw233,
sanjair-git and
yutongzhang-microsoft
August 7, 2026 23:04
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
@StormLiangMS @wangxin @yxieca A user wants to merge changes to the conditional mark files into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Enable
test_passive_peeringon T2 multi-ASIC by scoping BGP config commands to the correct ASIC namespace and removing the T2 skip.The test validates BGP passive peering and password authentication on T2 linecards. It identifies which ASIC owns the LLDP neighbor and resolves the namespace, but all config commands used
-n {asic_index}instead of the namespace name (-n asic0). Then, on multi-ASIC T2, config changes hit the wrong BGP instance, causing false failures. Session state checks via were already correct.Changes:
get_vtysh_cmd_for_asic()(similar to other multi-ASIC BGP tests).Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
N/A
Approach
What is the motivation for this PR?
On multi-ASIC topology, vtysh must target the ASIC namespace that owns the neighbor session. The test used numeric ASIC indices instead of namespace names, so passive/password config did not apply to the correct BGP instance.
How did you do it?
vtysh -n {asic_index} ...commands withget_vtysh_cmd_for_asic()for all DUT config steps.tests_mark_conditions_vs_t2.yaml.How did you verify/test it?
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
Existing test, updated logic to support T2.
Documentation
N/A.