Test_Prefix_List - T2 Update - #26895
Open
sresri2 wants to merge 1 commit into
Open
Conversation
Signed-off-by: sresri2 <125845681+sresri2@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
github-actions
Bot
requested review from
cyw233,
sanjair-git and
yutongzhang-microsoft
August 7, 2026 22:49
|
@StormLiangMS @wangxin @yxieca A user wants to merge changes to the conditional mark files into |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Enable
test_prefix_liston T2 multi-ASIC by fixing per-ASIC BGP/FIB verification and removing the T2 skip.test_prefix_list.pyalready loops over frontend ASICs, but the BGP check used an incorrect namespace, which could falsely report routes missing on multi-ASIC T2. The FIB check used the correct format but was open-coded. The test was skipped on VS T2.Changes:
test_prefix_list_suppress.py).Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
N/A
Approach
What is the motivation for this PR?
On multi-ASIC chassis, BGP verification needs to query each frontend ASIC's BGP instance. The test used the wrong namespace format for BGP checks, while FIB checks already used the correct ASIC namespace. This caused incorrect failures on multi-ASIC T2 even when the necessary routes were present.
How did you do it?
verify_prefix_in_bgp_table()to build vtysh commands by ASIC.verify_prefix_in_fib_table()to useget_db_cli_prefix()for consistency with the other multi-ASIC BGP tests.tests_mark_conditions_vs_t2.yaml.How did you verify/test it?
tests/common/helpers/bgp.py.Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
Existing test, updated logic for T2.
Documentation
N/A - simple test logic update for T2.