Test_FRR_Config_Check T1 Update - #26894
Open
sresri2 wants to merge 3 commits into
Open
Conversation
Signed-off-by: sresri2 <125845681+sresri2@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
github-actions
Bot
requested review from
cyw233,
sanjair-git and
yutongzhang-microsoft
August 7, 2026 22:35
|
@StormLiangMS @wangxin @yxieca A user wants to merge changes to the conditional mark files into |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
- Missing whitespace for static analysis check Signed-off-by: sresri2 <125845681+sresri2@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Enable
test_frr_config_checkon multi-ASIC T1 by scoping FRR file reads and 'show running-config' to each frontend ASIC. Behavior on T0 / single-ASIC T1 remains the same.The test previously compared FRR config files against
vtyshrunning-config, but it only used the global frr path and host-levelvtysh. On multi-ASIC DUTs, each frontend ASIC runs its ownbgp{N}container and requiresvtyshscoped per-ASIC. Due to the restriction, the test was skipped on VS T1 multi-ASIC.Changes:
_collect_missing_frr_configs()to verify all frontend ASICs.Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
N/A
Approach
What is the motivation for this PR?
test_frr_config_checkvalidates that FRR on-disk config files match the live running-config after config reload. The test logic was originally written just for single-ASIC topologies and was skipped on VS T1 multi-ASIC because it only inspected the default BGP instance and host FRR paths rather than per-ASIC containers as needed on multi-ASIC topologies.How did you do it?
bgp{N}container.tests_mark_conditions_vs_t1_multiasic.yaml.How did you verify/test it?
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
Existing test, logic extended to
t1,t1-lag,t1-8-lag. Not applicable to T2 in this change.Documentation
N/A.