[pfcwd] Use XGS PFC generator for NH-4210 - #26890
Open
deerao02 wants to merge 1 commit into
Open
Conversation
Map the NH-4210 fanout HWSKU to Tomahawk6 so PFC storm tests use the Broadcom XGS generator and matching templates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8b2808b-4ddf-4ad6-817e-e75f148c29fc
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
github-actions
Bot
requested review from
Javier-Tan,
cyw233 and
yutongzhang-microsoft
August 7, 2026 19:00
bingwang-ms
approved these changes
Aug 7, 2026
Collaborator
|
@gordon-nexthop FYI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Use the Broadcom XGS PFC generator for Nexthop NH-4210 SONiC fanouts by mapping the
NH-4210-F-O256HWSKU toTomahawk6.Fixes # (issue)
Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO): N/A
Failure type: day-one issue
Tested branch
Test result
pfc_gen_brcm_xgs.py -c Tomahawk6instead of the generic PFC generator.vms13-lt2-nh4210-1(lt2-u32d128,str4-nh4210-01), the all-port PFC storm test detected storm on 142/160 ports, exceeding the 75% threshold.git diff --checkpassed.Approach
What is the motivation for this PR?
The Nexthop NH-4210 fanout uses a Broadcom Tomahawk6 ASIC. Without an HWSKU-to-chip mapping, the PFC storm helper does not recognize this fanout as XGS-capable and selects the generic generator path. On the NH-4210 LT2 testbed, that path did not generate enough PFC traffic for the DUT to detect a storm.
How did you do it?
Added
NH-4210-F-O256toget_chip_name_if_asic_pfc_storm_supported()with theTomahawk6chip name. The existing SONiC XGS path then deployspfc_gen_brcm_xgs.pyand renders the XGS-compatible start and stop templates with the correct chip argument.How did you verify/test it?
Validated the all-port PFC watchdog storm test on
vms13-lt2-nh4210-1. The fanout ranpfc_gen_brcm_xgs.py -c Tomahawk6, and storm detection reached 142/160 ports. The IPv4 test passed; IPv6 reached storm state but failed later during restore. Also verified Python syntax and the LT2 start/stop template selection locally.Any platform specific information?
Nexthop NH-4210 HWSKU:
NH-4210-F-O256; Broadcom ASIC: Tomahawk6.Supported testbed topology if it's a new test case?
N/A; this updates generator selection for existing PFC watchdog tests on LT2.
Documentation
N/A; no user-facing interface or new test case.